Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GW190425 example fails due to a relative binning error #830

Closed
mj-will opened this issue Oct 11, 2024 · 4 comments
Closed

GW190425 example fails due to a relative binning error #830

mj-will opened this issue Oct 11, 2024 · 4 comments
Labels
bug Something isn't working likelihood

Comments

@mj-will
Copy link
Collaborator

mj-will commented Oct 11, 2024

The GW190425 example currently fails with the following error that is related to relative binning:

Traceback (most recent call last):
  File "/home/mjwill/git_repos/bilby/examples/gw_examples/data_examples/GW190425.py", line 118, in <module>
    likelihood = bilby.gw.likelihood.RelativeBinningGravitationalWaveTransient(
  File "/home/mjwill/git_repos/bilby/bilby/gw/likelihood/relative.py", line 148, in __init__
    self.compute_summary_data()
  File "/home/mjwill/git_repos/bilby/bilby/gw/likelihood/relative.py", line 334, in compute_summary_data
    stop = masked_frequency_array[end_idx]
IndexError: index 62977 is out of bounds for axis 0 with size 62977

I suspect this means there's a bug in the relative binning likelihood.

@mj-will mj-will added bug Something isn't working likelihood labels Oct 11, 2024
@mj-will
Copy link
Collaborator Author

mj-will commented Oct 11, 2024

I've checked, and this example still ran in v2.2.2, so I believe this bug was introduced in 103a512#diff-b8983bc349cc3e1bc4986b6de834bf9493ef07528d022f86510032dce710718bR219.

@adivijaykumar do you have any insight into this?

@ColmTalbot
Copy link
Collaborator

Is this addressed by #48?

@mj-will
Copy link
Collaborator Author

mj-will commented Oct 11, 2024

Is this addressed by #48?

Ah, I'd missed that. I think it is.

@mj-will
Copy link
Collaborator Author

mj-will commented Nov 13, 2024

Closing this since #48 has been merged.

@mj-will mj-will closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working likelihood
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants