This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
fix: ssr exception in runtime #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@osnoser1 can you please describe the PR? I have no experience on this field and would be nice to have an explanation instead of reading code to understand what was wrong |
|
Done @dianjuar 👍🏼 |
dianjuar
reviewed
Nov 4, 2019
dianjuar
reviewed
Nov 4, 2019
dianjuar
reviewed
Nov 5, 2019
|
@osnoser1 Your PR is just awesome! I will run Unit Test and Sonar Analysis (I now, I now, the CI should be doing this)and tell you how it went. If nothing happens I will integrate your PR. THANK YOU!!!!! |
dianjuar
approved these changes
Nov 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In SSR runtime occurs two exceptions: window and document is not defined.
Issue Number: #18
What is the new behavior?
All exceptions are gone in ssr.
Does this PR introduce a breaking change?
Other information
This PR has two commits:
windowexception, not create the IntersectionObserver instance in ssr because it isn't work, and inject thedocumentby angular because in ssr that it is created by domino library that angular uses since version 6 .Closes #18