-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s3 disk validation step #22
base: main
Are you sure you want to change the base?
Conversation
@mzur |
I think using a database transaction for this would be quite elegant! Then you can use I would advise against using |
It just came to my mind: You can probably use the VolumeUrl validation rule directly here. No need to duplicate code (unless it prevents you from showing a helpful error message). |
@mzur |
I found that an exception is only thrown if the host url is incorrect. If the bucket name is missing or wrong, it just returns an empty list. |
Closes #4.