Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation in StoreVolumeFileLabel #1030

Open
mzur opened this issue Jan 7, 2025 · 0 comments
Open

Fix validation in StoreVolumeFileLabel #1030

mzur opened this issue Jan 7, 2025 · 0 comments
Labels

Comments

@mzur
Copy link
Member

mzur commented Jan 7, 2025

$this->label = Label::find($this->input('label_id'));

The label_id is used before it is validated in the form request. Since the label is required for authorization, we have to add a manual check if the value is an integer here.

Without validation, invalid input (e.g. a string) can produce a server error.

@mzur mzur added the bug label Jan 7, 2025
@mzur mzur moved this from High Priority to Medium Priority in BIIGLE Roadmap Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Medium Priority
Development

No branches or pull requests

1 participant