You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When navigating through the UI and editing different styles, no changes should be made unless specifically updated by a user.
Actual Behavior
When navigating to a block with spacing set in the theme.json, the styles update to clear the spacing.
Step-by-step reproduction instructions
Set theme to Twenty Twenty Four
Activate Themer
Go to Appearance > Styles Editor
Navigate to Blocks > Quote
Notice the quote block will update to remove existing spacing values
Screenshots, screen recordings, code snippets
This is noticeable in the visual preview from #111 and less obvious when viewing the 'code preview'. However, note that the original spacing in theme.json is:
It's likely this is due to the component failing to parse the original value, perhaps due to use of calc or var. As well as (or instead of?) fixing this instance, we should prevent the value from updating when the parsing has failed, or we could unexpectedly hit this issue again.
I've been looking into this for a bit and I thought I would update the issue with where im at. Seems to happen in this part of ThemerComponent.js http://bigbite.im/i/GZ74va
It does this wierd thing where on the last 2 renders of the load it sets the object to 0px 0px 0px 0px when the values its merging are not like that. I haven't been able to work out why its doing that yet but I will continue looking into it.
Expected Behavior
When navigating through the UI and editing different styles, no changes should be made unless specifically updated by a user.
Actual Behavior
When navigating to a block with spacing set in the theme.json, the styles update to clear the spacing.
Step-by-step reproduction instructions
Screenshots, screen recordings, code snippets
This is noticeable in the visual preview from #111 and less obvious when viewing the 'code preview'. However, note that the original spacing in theme.json is:
But when navigating to the Quote block, the styles will show:
Screen.Capture.on.2024-10-02.at.09-32-17.mp4
The text was updated successfully, but these errors were encountered: