Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing CLI raises warnings #2019

Closed
drammock opened this issue Jul 11, 2024 · 4 comments
Closed

Installing CLI raises warnings #2019

drammock opened this issue Jul 11, 2024 · 4 comments
Labels

Comments

@drammock
Copy link

might be time to do an audit of packages.json, bump some things to newest version and see what breaks.

$ npm install -g bids-validator
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported

added 979 packages in 32s

115 packages are looking for funding
  run `npm fund` for details
@effigies
Copy link
Collaborator

effigies commented Aug 1, 2024

Would be nice, but these are not direct dependencies. We do have a number of things that were not easily upgraded, so we've put on pause:

image

It would definitely be appreciated if you have time to figure out what it would take to relax these pins. That might be the source of some of these outdated indirect dependencies.

@effigies effigies added the legacy label Aug 1, 2024
@effigies
Copy link
Collaborator

effigies commented Aug 1, 2024

I should note that we're not actively developing the legacy, Node-based validator anymore. We are working on the schema validator, which is Deno-based.

@drammock
Copy link
Author

drammock commented Aug 1, 2024

I should note that we're not actively developing the legacy, Node-based validator anymore. We are working on the schema validator, which is Deno-based.

fair enough. In my view curating dependency pins is more "maintenance" than "active development", but 🤷🏻. To me a message like This module is not supported, and leaks memory. Do not use it seems worth making an exception. But if you disagree feel free to close as wontfix... I don't really have the time myself to futz around with dependency pins on an unfamiliar repo.

@effigies
Copy link
Collaborator

effigies commented Aug 1, 2024

These specific dependencies are in the test runner's depencency tree: https://npmgraph.js.org/?q=jest

Seems that they know and the release of jest 30 should resolve it: jestjs/jest#15173

@effigies effigies closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants