Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a new gem #37

Open
simmerz opened this issue Apr 25, 2023 · 16 comments
Open

Cut a new gem #37

simmerz opened this issue Apr 25, 2023 · 16 comments

Comments

@simmerz
Copy link
Contributor

simmerz commented Apr 25, 2023

Currently running a few versions behind on rubygems. @bharget could you cut a new gem?

@kwent
Copy link

kwent commented Sep 29, 2023

I second this !

@didlix
Copy link

didlix commented Oct 4, 2023

+1 @bharget

@collimarco
Copy link

@bharget Thanks for this gem.

Is it still maintained?
Do you have any plans to update the icons to the latest version?

@nthj
Copy link

nthj commented Jan 31, 2024

I asked @bharget if he could use some help maintaining the gem on twitter

@marckohlbrugge
Copy link

First things first, I appreciate @bharget's work on this gem 🙌

Having said that, it seems like his priorities have shifted and this gem might benefit from a new maintainer or a fork.

@jclusso, considering your work in your most recent PR, would you be open to hosting it as a fork? I think a lot of us would appreciate it.

@simmerz
Copy link
Contributor Author

simmerz commented Apr 25, 2024

If @bharget could transfer it to us we could all maintain it. Would need access to continue publishing under the same name to rubygems too.

@jclusso
Copy link

jclusso commented Apr 25, 2024

@marckohlbrugge sure. @simmerz I'm already cutting a new gem as we speak. I just am not sure what we call it. It seems like nobody has been able to get him to do that based on:

I asked @bharget if he could use some help maintaining the gem on twitter

@simmerz
Copy link
Contributor Author

simmerz commented Apr 25, 2024

Beyond that, I'd suggest calling it heroicon-rails. That is a kind of convention where a thing gets bundled specifically for Rails, and that's happened here by virtue of the Rails dependency.

@jclusso
Copy link

jclusso commented Apr 25, 2024

@marckohlbrugge @simmerz that was already taken. I ended up going with heroicon-ruby since I couldn't think of anything else. https://github.com/jclusso/heroicon-ruby

@simmerz
Copy link
Contributor Author

simmerz commented Apr 25, 2024

Perhaps we use that as a reason to reduce the deps down to railties as per the other PR?

@jclusso
Copy link

jclusso commented Apr 25, 2024

@simmerz hah we think alike!

@marckohlbrugge
Copy link

marckohlbrugge commented Apr 25, 2024

@marckohlbrugge @simmerz that was already taken. I ended up going with heroicon-ruby since I couldn't think of anything else. https://github.com/clusso/heroicon-ruby

Your repo doesn't have Issues enabled, so I'll post it here:

@chunlea has the heroicons Rubygem name for chunlea/heroicons-ruby and is willing to release it for this fork. I think it would be a great name, matching the icon set which is also the plural "heroicons".

What do you think?

@chunlea
Copy link

chunlea commented Apr 25, 2024

Hi, all. I am the creator of https://rubygems.org/gems/heroicons, but mine version never well maintained. And thanks for @marckohlbrugge to contact me, I am okay to release this name to the community. Let's me know what next we should do.

@jclusso
Copy link

jclusso commented Apr 25, 2024

@chunlea that would be awesome! If you add me as an owner on Rubygems that would be great. My username is the same as here, jclusso.

@chunlea
Copy link

chunlea commented Apr 25, 2024

@jclusso invite sent. And since my version is 0.1.0, for new version, we can bump that version number so we didn't break old one. And thanks for your contribution to maintain a up to date version.

@jclusso
Copy link

jclusso commented Apr 27, 2024

For anyone coming here in the future, I've created a fork, cleaned up the gem, and got it up to date. It's now being released under heroicons, thanks to @chunlea for his donation of that gem. Also @simmerz generously offered to help with maintanence in the future. I'll work to keep it more active.

https://github.com/jclusso/heroicons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants