Unable to show all row

[sameer1750]

So Displaying all row from the dropdown does not work
My javascript code has this :
"lengthMenu": [
[10, 25, 50, 75, 100, -1],
[10, 25, 50, 75, 100, "All"] // change per page values here
],
So to display all values i am giving a value of -1 as read by me in datatables

But because of this function in datatables.php file it wont allow me to show all rows
protected function paging()
{
if(!is_null($this->input['start']) && !is_null($this->input['length']))
{
$this->query->skip($this->input['start'])->take((int)$this->input['length']>0?$this->input['length']:10);
}
}

A little change to this paging function would help

protected function paging()
{
if(!is_null($this->input['start']) && !is_null($this->input['length']))
{
if($this->input['length'] > 0){
$this->query->skip($this->input['start'])->take((int)$this->input['length']);
}
}
}

[MarkVaughn]

if this is still the case in 1.5 can you patch it?

[sameer1750]

how?

[sameer1750]

Yes i can but can you tell me how??

[MarkVaughn]

check out how to create pull requests here
https://help.github.com/articles/fork-a-repo/

Mark Vaughn
Mobile: +1 (770) 533-2274

On Wed, Feb 18, 2015 at 8:11 AM, sameer1750 [email protected]
wrote:

Yes i can but can you tell me how??

—
Reply to this email directly or view it on GitHub
#193 (comment)
.

[sameer1750]

I have comitted the changes, you can review it and push it.