From c016a9784ec6d211de6e7a5b897de1265bc3d1db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A1bor=20Varga?= Date: Tue, 29 Jan 2013 11:13:29 +0100 Subject: [PATCH] Fix memory leak in MGTwitterLibXMLParser. In case xmlReaderForMemory() fails, nil is returned from the initWithXML method, so the alloc should be reverted. --- Twitter+OAuth/MGTwitterEngine/MGTwitterLibXMLParser.m | 1 + 1 file changed, 1 insertion(+) diff --git a/Twitter+OAuth/MGTwitterEngine/MGTwitterLibXMLParser.m b/Twitter+OAuth/MGTwitterEngine/MGTwitterLibXMLParser.m index 77ad478..91a7344 100644 --- a/Twitter+OAuth/MGTwitterEngine/MGTwitterLibXMLParser.m +++ b/Twitter+OAuth/MGTwitterEngine/MGTwitterLibXMLParser.m @@ -50,6 +50,7 @@ - (id)initWithXML:(NSData *)theXML delegate:(NSObject * _reader = xmlReaderForMemory([xml bytes], [xml length], [[URL absoluteString] UTF8String], nil, XML_PARSE_NOBLANKS | XML_PARSE_NOCDATA | XML_PARSE_NOERROR | XML_PARSE_NOWARNING); if (! _reader) { + [self release]; return nil; }