Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface with TextAnalysis.jl? #10

Open
ericphanson opened this issue Dec 8, 2020 · 0 comments
Open

Interface with TextAnalysis.jl? #10

ericphanson opened this issue Dec 8, 2020 · 0 comments

Comments

@ericphanson
Copy link
Member

ericphanson commented Dec 8, 2020

Document's could be TextAnalysis.StringDocument and Corpus could be TextAnalysis.Corpus?

  • This would mean KeywordSearch complements TextAnalysis by providing fuzzy-matching capabilities its StringDocument types and Corpuses of StringDocuments.
  • It would also mean that it's easy to do other types of analyses (provided by TextAnalysis) beyond keyword searching on documents loaded into this library, since they would already be TextAnalysis.Corpuses.
  • Currently, we allow attaching arbitrary NamedTuple metadata to our documents or corpuses, which I use for storing document UUIDs and corpus UUIDs. This maybe could be upstreamed to maintain the functionality.
  • This would also enlarge the dependency tree of KeywordSearch, since we would need to add a dependency on TextAnalysis (https://juliahub.com/ui/Packages/TextAnalysis/5Mwet/0.7.1?t=1).

This would be for the future (not the 0.3 release I want to get out soon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant