From 6f916ef178bd6947d39a5bbe11bace200bb45721 Mon Sep 17 00:00:00 2001 From: Brandon Galli <54678642+flutistar@users.noreply.github.com> Date: Wed, 17 Jul 2024 00:56:44 +0800 Subject: [PATCH] fixed error on person giving note (#1980) * fixed error on person giving note * changed version number * addressed comments --- ppr-ui/package-lock.json | 4 ++-- ppr-ui/package.json | 2 +- ppr-ui/src/components/unitNotes/UnitNoteReview.vue | 2 +- ppr-ui/src/composables/mhrInformation/useMhrUnitNote.ts | 1 + 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/ppr-ui/package-lock.json b/ppr-ui/package-lock.json index 4378fb03b..3b6396522 100644 --- a/ppr-ui/package-lock.json +++ b/ppr-ui/package-lock.json @@ -1,12 +1,12 @@ { "name": "ppr-ui", - "version": "3.2.38", + "version": "3.2.39", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "ppr-ui", - "version": "3.2.38", + "version": "3.2.39", "dependencies": { "@bcrs-shared-components/input-field-date-picker": "^1.0.0", "@lemoncode/fonk": "^1.5.1", diff --git a/ppr-ui/package.json b/ppr-ui/package.json index 983196e3a..59c17a7ea 100644 --- a/ppr-ui/package.json +++ b/ppr-ui/package.json @@ -1,6 +1,6 @@ { "name": "ppr-ui", - "version": "3.2.38", + "version": "3.2.39", "private": true, "appName": "Assets UI", "sbcName": "SBC Common Components", diff --git a/ppr-ui/src/components/unitNotes/UnitNoteReview.vue b/ppr-ui/src/components/unitNotes/UnitNoteReview.vue index 14076060e..091bb4613 100644 --- a/ppr-ui/src/components/unitNotes/UnitNoteReview.vue +++ b/ppr-ui/src/components/unitNotes/UnitNoteReview.vue @@ -198,7 +198,7 @@ export default defineComponent({ const localState = reactive({ validateSubmittingParty: false, - initialAttention: getMhrUnitNoteRegistration.value?.attentionReference, + initialAttention: isCancelUnitNote.value ? '' : getMhrUnitNoteRegistration.value?.attentionReference, unitNoteType: UnitNotesInfo[getMhrUnitNote.value.documentType], givingNoticeParty: computed((): PartyIF => getMhrUnitNote.value.givingNoticeParty), unitNoteSubmittingParty: computed(() => getMhrUnitNoteRegistration.value.submittingParty || {}), diff --git a/ppr-ui/src/composables/mhrInformation/useMhrUnitNote.ts b/ppr-ui/src/composables/mhrInformation/useMhrUnitNote.ts index 6e3cdf892..d77951dff 100644 --- a/ppr-ui/src/composables/mhrInformation/useMhrUnitNote.ts +++ b/ppr-ui/src/composables/mhrInformation/useMhrUnitNote.ts @@ -190,6 +190,7 @@ export const useMhrUnitNote = () => { cancelUniNote.documentType = UnitNoteDocTypes.NOTE_CANCELLATION cancelUniNote.documentId = '' cancelUniNote.destroyed = false + cancelUniNote.hasNoPersonGivingNotice = !note.givingNoticeParty setMhrUnitNoteRegistration({ key: 'cancelDocumentId', value: note.documentId }) setMhrUnitNoteRegistration({ key: 'submittingParty', value: null })