Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Web staff dashboard: submitter should not be "undefined" #24080

Open
severinbeauvais opened this issue Oct 28, 2024 · 10 comments
Open

Auth Web staff dashboard: submitter should not be "undefined" #24080

severinbeauvais opened this issue Oct 28, 2024 · 10 comments
Assignees
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority2

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 28, 2024

The original submitter name shows as "undefined".

The re-submitter name is not even shown.

image.png

The root cause is that we no longer capture the Completing Party as this is an authorization only -- but we do have the submitter's login. (Note that we also don't support multiple submitters.)

Option 1: Show the authorization submitter from the filing's header.submitter property. (Right now this is the encoded login but we could update the review endpoint to provide the decoded name.) We would only be able to display one submitter -- the original one or the latest one. I suggest the latest one as being most useful.

Option 2: Don't show the authorization submitter, since we already don't show it for a resubmission.

@severinbeauvais severinbeauvais added bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Oct 28, 2024
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Oct 29, 2024

Duplicate ticket: #24078

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Oct 31, 2024

Also, the line should say "Authorization Submitted" (not Application).

@ArwenQin ArwenQin assigned ArwenQin and unassigned ArwenQin Oct 31, 2024
@severinbeauvais
Copy link
Collaborator Author

@jacqueline-williams-549 @janisrogers Please see the description for possible options. Do you have a preference? Thanks!

@janisrogers
Copy link
Collaborator

My preference would be option 1, but I am okay with option 2.

@severinbeauvais
Copy link
Collaborator Author

@OlgaPotiagalova Could you please decide whether we should implement option 1 or option 2?

Option 1 is more work (est: 1 for UI, 2 for API) but provides a better experience because it should the submitter name.

Option 2 is almost no work (est: 1 for UI).

@OlgaPotiagalova OlgaPotiagalova self-assigned this Nov 14, 2024
@severinbeauvais
Copy link
Collaborator Author

Blocked while awaiting PO decision.

@OlgaPotiagalova
Copy link
Collaborator

OlgaPotiagalova commented Jan 3, 2025

Considering the release timeline and the effort, please implement solution 2 for now.

Create a separate ticket(s) to capture the submitter information (from login account), model it in the db, and display it in the staff dashboard, for future implementation.

@severinbeauvais
Copy link
Collaborator Author

@ArwenQin Please work on this ticket. See comments above for the decisions we made.

@ArwenQin
Copy link
Collaborator

ArwenQin commented Jan 9, 2025

Created #25230 for future implementation.

@seeker25
Copy link
Collaborator

Deployed to PROD, this is low risk (small wording change see PR bcgov/sbc-auth#3202 also I don't think continuation IN is active on PROD).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority2
Projects
None yet
Development

No branches or pull requests

6 participants