Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit UI - display correct name for SP/GP #15602

Closed
4 tasks done
severinbeauvais opened this issue Mar 10, 2023 · 4 comments
Closed
4 tasks done

Edit UI - display correct name for SP/GP #15602

severinbeauvais opened this issue Mar 10, 2023 · 4 comments
Assignees
Labels
ENTITY Business Team

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Mar 10, 2023

TODO:

  • Do work in feature branch pointing at the GCP hosted Legal API -- https://business-api-dy4loprnwa-nn.a.run.app/api/v2/.
  • Determine where the Legal Name is used/displayed in Edit UI.
  • Update code to use Operating Name from "alternateNames" array if the business is a firm (SP or GP) where it was previously using "legalName" field from the business response. The logic to determine which operating name to be use is "business.identifier" == "alternateNames.identifier".
  • add new unit tests

See #15600 for more details.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Oct 13, 2023

Test Notes

The following filings are impacted by this change:

  1. firm change filing
  2. firm conversion filing
  3. firm correction filing

Because the new (Legal Name) API needs to be used for this, and these filings normally come from Filings UI, you can navigate directly to these pages for testing:

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Oct 16, 2023

Test Results

Change filing for FM1017608

  • Legal Name is "ASHNA MEHTA"
  • Operating Name is "GOVNSP"

Initial view (no draft filing). Breadcrumb looks OK; entity header looks OK; business name looks OK:
image

Initial view (no draft filing) with name change NR. Breadcrumb as before, entity header as before; business name shows NR approved name:
image

Resumed draft. Breadcrumb as before; entity header as before; business name shows NR approved name:
image

Conversion filing for FM1017608

  • Legal Name is "ASHNA MEHTA"
  • Operating Name is "GOVNSP"

Initial view (no draft filing). Breadcrumb looks OK; entity header looks OK; business name looks OK:
image

Resumed draft. Breadcrumb looks OK; entity header looks OK; business name looks OK:
image

Correction filing for FM1018102

  • Legal Name is "TRTRTR TRTR"
  • Operating Name is "SSSSSSSSSSSSSPPPPPPPPPPPP"

Initial draft (no changes). Breadcrumb looks OK; entity header looks OK; business name looks OK:
image

Initial draft with name change NR. Breadcrumb as before, entity header as before; business name shows NR approved name:
image

Resume draft. Breadcrumb as before; entity header as before; business name shows NR approved name:
image

@severinbeauvais
Copy link
Collaborator Author

@riyazuddinsyed : Note that you can file any of these 3 filings but Pay isn't integrated yet and neither is the Filer, so your filing will end up looking like this:

image

(You also won't be able to cancel the payment.)

This is expected right now. Actually filing firm change/conversion/corrections should be tested when we move the Legal Name changes into Dev.

cc: @argush3

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Oct 25, 2023

I have created a new PR to merge the feature branch into main branch, though it is NOT READY TO MERGE yet -- but I will use it to create the GCB preview site. See that PR (and the original PR) for sample URLs and URL parameters.

@jdyck-fw jdyck-fw closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

3 participants