From 0b8cd3b6db230e9dec1b8fabf40c51af9e817439 Mon Sep 17 00:00:00 2001
From: deetz99 <73151365+deetz99@users.noreply.github.com>
Date: Tue, 31 Dec 2024 15:35:08 -0800
Subject: [PATCH] Host - UI: Bug fixes (#425)

* remove rental doc from required docs when exempt
* remove rental doc from requried when pr not required
* make sin required
* validate all bc id cards as max 1 document
* remove pr declaration from review step if user exempt
* reset fee widget on variable change
* format fax number the same as phone number
* bump host version
---
 .../app/components/form/common/Contact.vue    |  3 ++-
 .../form/AddOwners/input/Person.vue           |  3 ++-
 .../app/components/form/Review/Index.vue      | 11 +++++++++-
 strr-host-pm-web/app/pages/application.vue    |  7 ++++---
 strr-host-pm-web/app/stores/document.ts       | 20 ++++++++++++++-----
 strr-host-pm-web/app/stores/hostOwner.ts      |  4 +++-
 strr-host-pm-web/package.json                 |  2 +-
 strr-platform-web/package.json                |  2 +-
 strr-strata-web/package.json                  |  2 +-
 9 files changed, 39 insertions(+), 15 deletions(-)

diff --git a/strr-base-web/app/components/form/common/Contact.vue b/strr-base-web/app/components/form/common/Contact.vue
index 68cfafbb..4ff329c4 100644
--- a/strr-base-web/app/components/form/common/Contact.vue
+++ b/strr-base-web/app/components/form/common/Contact.vue
@@ -49,7 +49,7 @@ defineProps<{
           name="fullName"
           :placeholder="t('label.fullName')"
         />
-        <div v-else class="max-w-bcGovInput flex flex-col gap-3 sm:flex-row">
+        <div v-else class="flex max-w-bcGovInput flex-col gap-3 sm:flex-row">
           <ConnectFormFieldGroup
             v-if="firstName !== undefined"
             :id="idPrefix + '-first-name'"
@@ -118,6 +118,7 @@ defineProps<{
           :aria-label="t('label.faxNumberOpt')"
           name="faxNumber"
           :placeholder="t('label.faxNumberOpt')"
+          :mask="phone?.countryCode === '1' ? '(###) ###-####' : '##############'"
         />
         <ConnectFormFieldGroup
           v-if="emailAddress !== undefined"
diff --git a/strr-host-pm-web/app/components/form/AddOwners/input/Person.vue b/strr-host-pm-web/app/components/form/AddOwners/input/Person.vue
index cf73bdcf..113ab61e 100644
--- a/strr-host-pm-web/app/components/form/AddOwners/input/Person.vue
+++ b/strr-host-pm-web/app/components/form/AddOwners/input/Person.vue
@@ -141,7 +141,7 @@ watch(isCompParty, (val) => {
           id="host-owner-taxNumber"
           v-model="owner.taxNumber"
           name="taxNumber"
-          :placeholder="$t('label.craTaxNumberOpt')"
+          :placeholder="$t('label.craTaxNumber')"
           :help="$t('strr.hint.craTaxNumber')"
           mask="### ### ###"
         />
@@ -197,6 +197,7 @@ watch(isCompParty, (val) => {
           :aria-label="$t('label.faxNumberOpt')"
           name="faxNumber"
           :placeholder="$t('label.faxNumberOpt')"
+          :mask="owner.phone.countryCode === '1' ? '(###) ###-####' : '##############'"
         />
       </ConnectFormSection>
       <ConnectFormSection
diff --git a/strr-host-pm-web/app/components/form/Review/Index.vue b/strr-host-pm-web/app/components/form/Review/Index.vue
index 8465f88d..136b4b6c 100644
--- a/strr-host-pm-web/app/components/form/Review/Index.vue
+++ b/strr-host-pm-web/app/components/form/Review/Index.vue
@@ -13,6 +13,7 @@ const ownerStore = useHostOwnerStore()
 const { hasCompParty, hostOwners } = storeToRefs(ownerStore)
 const documentsStore = useDocumentStore()
 const applicationStore = useHostApplicationStore()
+const reqStore = usePropertyReqStore()
 
 const confirmationFormRef = ref<Form<z.output<typeof applicationStore.confirmationSchema>>>()
 const sectionErrors = ref<MultiFormValidationResult>([])
@@ -65,6 +66,14 @@ const getCompPartyName = computed(() => {
   }
   return `[${t('label.completingParty')}]`
 })
+
+const agreedToRentalActListItems = computed(() => {
+  if (reqStore.hasReqs && (!reqStore.propertyReqs.isPrincipalResidenceRequired || reqStore.prRequirements.prExemptionReason !== undefined)) {
+    return [{ slot: 'item-1' }, { i18nKey: 'certify.2' }, { i18nKey: 'certify.4' }]
+  } else {
+    return [{ slot: 'item-1' }, { i18nKey: 'certify.2' }, { i18nKey: 'certify.3' }, { i18nKey: 'certify.4' }]
+  }
+})
 </script>
 <template>
   <div class="space-y-10" data-testid="strata-review-confirm">
@@ -125,7 +134,7 @@ const getCompPartyName = computed(() => {
     >
       <ConnectFormCertify
         v-model="applicationStore.userConfirmation.agreedToRentalAct"
-        :items="[{ slot: 'item-1' }, { i18nKey: 'certify.2' }, { i18nKey: 'certify.3' }, { i18nKey: 'certify.4' }]"
+        :items="agreedToRentalActListItems"
         :checkbox-label="{ key: 'certify.confirm', props: { name: getCompPartyName } }"
         :has-error="isComplete && hasFormErrors(confirmationFormRef, ['agreedToRentalAct'])"
         name="agreedToRentalAct"
diff --git a/strr-host-pm-web/app/pages/application.vue b/strr-host-pm-web/app/pages/application.vue
index 84c5d97f..7a6a0e85 100644
--- a/strr-host-pm-web/app/pages/application.vue
+++ b/strr-host-pm-web/app/pages/application.vue
@@ -53,6 +53,7 @@ const setFeeBasedOnProperty = () => {
     return
   }
   if (propertyTypeFeeTriggers.value.isEntireHomeAndPrincipalResidence) {
+    hostFee3.value.quantity = 1
     removeFee(StrrFeeCode.STR_HOST_2)
     addReplaceFee(hostFee1.value)
   } else if (propertyTypeFeeTriggers.value.isEntireHomeAndNotPrincipalResidence) {
@@ -62,15 +63,15 @@ const setFeeBasedOnProperty = () => {
     removeFee(StrrFeeCode.STR_HOST_1)
     removeFee(StrrFeeCode.STR_HOST_2)
     hostFee3.value.quantity = unitDetails.value.numberOfRoomsForRent || 1
-    hostFee3.value.quantityDesc = hostFee3.value.quantity > 1
-      ? t('strr.word.room', hostFee3.value.quantity)
-      : undefined
     addReplaceFee(hostFee3.value)
   } else {
     // set placeholder
     removeFee(StrrFeeCode.STR_HOST_1)
     removeFee(StrrFeeCode.STR_HOST_2)
   }
+  hostFee3.value.quantityDesc = hostFee3.value.quantity !== undefined && hostFee3.value.quantity > 1
+    ? t('strr.word.room', hostFee3.value.quantity)
+    : undefined
 }
 
 // manage fees only when typeofspace and rentalUnitSetupType change
diff --git a/strr-host-pm-web/app/stores/document.ts b/strr-host-pm-web/app/stores/document.ts
index 466e55b6..4caf6b37 100644
--- a/strr-host-pm-web/app/stores/document.ts
+++ b/strr-host-pm-web/app/stores/document.ts
@@ -65,7 +65,7 @@ export const useDocumentStore = defineStore('host/document', () => {
       })
     }
 
-    if (propStore.unitDetails.ownershipType === OwnershipType.RENT) {
+    if (propStore.unitDetails.ownershipType === OwnershipType.RENT && reqs.isPrincipalResidenceRequired && exemptionReason === undefined) {
       const isRentValid = apiDocuments.value.some(
         item => [DocumentUploadType.TENANCY_AGREEMENT, DocumentUploadType.RENT_RECEIPT_OR_BANK_STATEMENT]
           .includes(item.documentType)
@@ -255,11 +255,15 @@ export const useDocumentStore = defineStore('host/document', () => {
   }
 
   function validatePrincipalResidenceDocuments (): boolean {
-    // either 2 unique docs from this list are required
-    const uniqueColumnADocs = [
+    // bc id cards only count as 1 document
+    const bcIdDocs = [
       DocumentUploadType.BC_DRIVERS_LICENSE,
       DocumentUploadType.BCSC,
-      DocumentUploadType.COMBINED_BCSC_LICENSE,
+      DocumentUploadType.COMBINED_BCSC_LICENSE
+    ]
+
+    // either 2 unique docs from this list are required
+    const uniqueColumnADocs = [
       DocumentUploadType.PROPERTY_ASSESSMENT_NOTICE,
       DocumentUploadType.SPEC_TAX_CONFIRMATION,
       DocumentUploadType.HOG_DECLARATION
@@ -299,8 +303,14 @@ export const useDocumentStore = defineStore('host/document', () => {
 
     // get non-unique column b docs
     const columnBFilteredNonUnique = apiDocuments.value.filter(item => nonUniqueColumnBDocs.includes(item.documentType))
+
+    // get bc id docs
+    const bcIdDocsExist = apiDocuments.value.some((doc) => bcIdDocs.includes(doc.documentType))
+    // only count bcid docs as 1 document
+    const bcIdDocCount = bcIdDocsExist ? 1 : 0
+
     // get doc count
-    const columnACount = columnAFilteredUnique.length
+    const columnACount = columnAFilteredUnique.length + bcIdDocCount
     const columnBCount = columnBFilteredUnique.length + columnBFilteredNonUnique.length
 
     // validate at least 2 of column a docs OR validate at least 1 of column a and 2 of column b
diff --git a/strr-host-pm-web/app/stores/hostOwner.ts b/strr-host-pm-web/app/stores/hostOwner.ts
index 461ae5e6..d55bde81 100644
--- a/strr-host-pm-web/app/stores/hostOwner.ts
+++ b/strr-host-pm-web/app/stores/hostOwner.ts
@@ -32,7 +32,9 @@ export const useHostOwnerStore = defineStore('host/owner', () => {
       dateOfBirth: type === OwnerType.INDIVIDUAL && role === OwnerRole.HOST
         ? getRequiredNonEmptyString(t('validation.dateOfBirth'))
         : optionalOrEmptyString,
-      taxNumber: getOptionalSin(t('validation.sin'))
+      taxNumber: type === OwnerType.INDIVIDUAL && role === OwnerRole.HOST 
+        ? getRequiredSin(t('validation.sin'))
+        : optionalOrEmptyString
     })
   }
 
diff --git a/strr-host-pm-web/package.json b/strr-host-pm-web/package.json
index 5a85896e..d1ec5f46 100644
--- a/strr-host-pm-web/package.json
+++ b/strr-host-pm-web/package.json
@@ -2,7 +2,7 @@
   "name": "strr-host-pm-web",
   "private": true,
   "type": "module",
-  "version": "0.0.21",
+  "version": "0.0.22",
   "scripts": {
     "build-check": "nuxt build",
     "build": "nuxt generate",
diff --git a/strr-platform-web/package.json b/strr-platform-web/package.json
index 0bfb5cd7..dd263446 100644
--- a/strr-platform-web/package.json
+++ b/strr-platform-web/package.json
@@ -2,7 +2,7 @@
   "name": "strr-platform-web",
   "private": true,
   "type": "module",
-  "version": "0.0.31",
+  "version": "0.0.32",
   "scripts": {
     "build-check": "nuxt build",
     "build": "nuxt generate",
diff --git a/strr-strata-web/package.json b/strr-strata-web/package.json
index 01603862..666f3e83 100644
--- a/strr-strata-web/package.json
+++ b/strr-strata-web/package.json
@@ -2,7 +2,7 @@
   "name": "strr-strata-web",
   "private": true,
   "type": "module",
-  "version": "0.0.31",
+  "version": "0.0.32",
   "scripts": {
     "build-check": "nuxt build",
     "build": "nuxt generate",