diff --git a/backend/src/components/institute/institute.js b/backend/src/components/institute/institute.js
index c0d7da23f..fb5d790a5 100644
--- a/backend/src/components/institute/institute.js
+++ b/backend/src/components/institute/institute.js
@@ -1,5 +1,5 @@
'use strict';
-const { logApiError, getData, errorResponse } = require('../utils');
+const { logApiError, getData, errorResponse} = require('../utils');
const HttpStatus = require('http-status-codes');
const cacheService = require('../cache-service');
const {FILTER_OPERATION, VALUE_TYPE, CONDITION} = require('../../util/constants');
@@ -1026,8 +1026,28 @@ async function getSchoolHistoryPaginated(req, res) {
searchCriteriaList: JSON.stringify(historySearchCriteria)
}
};
- let response = await getData(config.get('server:institute:rootURL') + '/school/history/paginated', schoolHistorySearchParam);
- return res.status(HttpStatus.OK).json(response);
+
+ Promise.all([
+ getData(config.get('server:edx:edxUsersURL')),
+ getData(config.get('server:institute:rootURL') + '/school/history/paginated', schoolHistorySearchParam)
+ ])
+ .then(async ([edxUserResponse, schoolHistoryResponse]) => {
+ if (edxUserResponse && schoolHistoryResponse) {
+ schoolHistoryResponse.content.forEach((element) => {
+ if(element.updateUser?.length > 10){
+ let val = edxUserResponse.find(user => user.edxUserID === element.updateUser.replace('EDX/', ''));
+ if(val){
+ element.updateUser = (val.firstName + ' ' + val.lastName).trim();
+ }
+ }
+ });
+
+ return res.status(HttpStatus.OK).json(schoolHistoryResponse);
+ }
+ }).catch(async e => {
+ await logApiError(e, 'getSchoolsPaginated', 'Error occurred while attempting to GET schools paginated.');
+ return errorResponse(res);
+ });
} catch (e) {
logApiError(e, 'getSchoolsPaginated', 'Error occurred while attempting to GET schools paginated.');
return errorResponse(res);
diff --git a/frontend/src/components/institute/MoveSchoolPage.vue b/frontend/src/components/institute/MoveSchoolPage.vue
index c016860ca..972bd3f19 100644
--- a/frontend/src/components/institute/MoveSchoolPage.vue
+++ b/frontend/src/components/institute/MoveSchoolPage.vue
@@ -352,14 +352,16 @@
no-gutters
class="pt-4"
>
-
+
+
+
-
+
!this.independentArray.includes(cat.schoolCategoryCode) && !this.offshoreArray.includes(cat.schoolCategoryCode) && cat.schoolCategoryCode !== 'YUKON') : [];
- if(this.canMoveOtherSchoolTypes) {
+ let publicOnlyTypes = this.activeSchoolCategoryTypeCodes
+ ? this.activeSchoolCategoryTypeCodes
+ .filter(cat =>
+ !this.independentArray.includes(cat.schoolCategoryCode)
+ && !this.offshoreArray.includes(cat.schoolCategoryCode)
+ && cat.schoolCategoryCode !== 'YUKON'
+ && cat.schoolCategoryCode !== 'POST_SEC'
+ )
+ : [];
+ if (this.canMoveOtherSchoolTypes) {
returnedCodes = publicOnlyTypes;
}
if (this.canMoveIndependentSchools) {
- returnedCodes = returnedCodes.concat(this.activeSchoolCategoryTypeCodes.filter(cat => this.independentArray.includes(cat.schoolCategoryCode)));
+ returnedCodes = returnedCodes
+ .concat(this.activeSchoolCategoryTypeCodes
+ .filter(cat => this.independentArray.includes(cat.schoolCategoryCode)));
}
return sortBy(returnedCodes, ['displayOrder']);
},
diff --git a/frontend/src/components/institute/NewSchoolPage.vue b/frontend/src/components/institute/NewSchoolPage.vue
index 628d5e05f..90313975f 100644
--- a/frontend/src/components/institute/NewSchoolPage.vue
+++ b/frontend/src/components/institute/NewSchoolPage.vue
@@ -355,14 +355,16 @@
no-gutters
class="pt-4"
>
-
+
+
+
@@ -447,7 +449,7 @@
no-gutters
class="pt-4"
>
-
+
@@ -137,6 +138,7 @@
:contact="editContact"
:school-contact-types="schoolContactTypes"
:school-i-d="$route.params.schoolID"
+ :school="school"
@editSchoolContact:cancelEditSchoolContactPage="editContactSheet = !editContactSheet"
@editSchoolContact:editSchoolContactSuccess="contactEditSuccess"
/>
diff --git a/frontend/src/components/institute/district/DistrictContacts.vue b/frontend/src/components/institute/district/DistrictContacts.vue
index bff1f3cba..09e087588 100644
--- a/frontend/src/components/institute/district/DistrictContacts.vue
+++ b/frontend/src/components/institute/district/DistrictContacts.vue
@@ -61,6 +61,7 @@
item-value="districtContactTypeCode"
:menu-props="{closeOnContentClick:true}"
label="Contact Type"
+ @update:model-value="searchButtonClicked"
/>
diff --git a/frontend/src/components/penreg/penrequest-batch/PenRequestBatchDisplay.vue b/frontend/src/components/penreg/penrequest-batch/PenRequestBatchDisplay.vue
index 845de4218..fb78fbff0 100644
--- a/frontend/src/components/penreg/penrequest-batch/PenRequestBatchDisplay.vue
+++ b/frontend/src/components/penreg/penrequest-batch/PenRequestBatchDisplay.vue
@@ -173,29 +173,12 @@
-
-
-
- {{ archiveAndReturnMessage }}
- {{ archiveAndReturnSubtext }}
-
-
-
- mdi-close
-
-
-
+
+ {{ archiveAndReturnMessage }}
+ {{ archiveAndReturnSubtext }}
-
+
@@ -398,7 +381,7 @@ export default {
const fileNumber = this.selectedFiles.length;
this.archiveAndReturnMessage = `Please confirm that you would like to return the response files to ${fileNumber} PEN request ${pluralize('file', fileNumber)}.`;
this.archiveAndReturnSubtext = 'Note this action will not return any files to the submitting school if FIXABLE requests exist.';
- const result = await this.$refs.fixableConfirmationDialog.open(null, null,
+ const result = await this.$refs.fixableConfirmationDialog.open('Please confirm your return submission', null,
{
width: '620px',
messagePadding: 'px-4 pt-4',
@@ -445,7 +428,7 @@ export default {
const fileNumber = this.selectedFiles.length;
this.archiveAndReturnMessage = `Please confirm that you would like to return the response files to ${fileNumber} PEN request ${pluralize('file', fileNumber)}.`;
this.archiveAndReturnSubtext = 'Note this action will return all files to the submitting school.';
- const result = await this.$refs.fixableConfirmationDialog.open(null, null,
+ const result = await this.$refs.fixableConfirmationDialog.open('Please confirm your return submission', null,
{
width: '520px',
messagePadding: 'px-4 pt-4',
diff --git a/frontend/src/components/penreg/penrequest-batch/PrbStudentSearchResults.vue b/frontend/src/components/penreg/penrequest-batch/PrbStudentSearchResults.vue
index c600f4c67..7ced0fe6c 100644
--- a/frontend/src/components/penreg/penrequest-batch/PrbStudentSearchResults.vue
+++ b/frontend/src/components/penreg/penrequest-batch/PrbStudentSearchResults.vue
@@ -71,7 +71,6 @@
-
-
+
-
+
+ {{ title }}
+
+
{{ message }}
+ />