From 0d9dfbbe2209dcc878348277f337314471c21115 Mon Sep 17 00:00:00 2001
From: Jen Beckett <115109120+jenbeckett@users.noreply.github.com>
Date: Thu, 19 Dec 2024 12:35:42 -0800
Subject: [PATCH 1/9] ccfri 4004, and other small ui bug fixes

---
 frontend/src/components/LandingPage.vue                |  4 ++--
 .../ccofApplication/group/OrganizationInformation.vue  |  8 +++++---
 .../src/components/requestChanges/ReportChanges.vue    | 10 +++++++---
 .../components/summary/group/OrganizationSummary.vue   |  6 +++---
 4 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/frontend/src/components/LandingPage.vue b/frontend/src/components/LandingPage.vue
index 78151723..2faac7fb 100644
--- a/frontend/src/components/LandingPage.vue
+++ b/frontend/src/components/LandingPage.vue
@@ -309,7 +309,7 @@
   </v-container>
 </template>
 <script>
-import { isEmpty } from 'lodash';
+import { isEmpty, orderBy } from 'lodash';
 import { mapState, mapActions } from 'pinia';
 import { useAuthStore } from '@/store/auth.js';
 import { useAppStore } from '@/store/app.js';
@@ -805,7 +805,7 @@ export default {
           return false;
         });
         if (mtfiChangeRequestListForFacility?.length > 0) {
-          mtfiChangeRequestListForFacility = _.orderBy(mtfiChangeRequestListForFacility, 'firstSubmissionDate', 'desc');
+          mtfiChangeRequestListForFacility = orderBy(mtfiChangeRequestListForFacility, 'firstSubmissionDate', 'desc');
           lastMTFIChangeRequest = mtfiChangeRequestListForFacility[0];
         }
       }
diff --git a/frontend/src/components/ccofApplication/group/OrganizationInformation.vue b/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
index c0b5f9cf..bb74e172 100644
--- a/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
+++ b/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
@@ -61,7 +61,7 @@
                     :disabled="isLocked"
                     variant="outlined"
                     required
-                    :rules="rules.required"
+                    :rules="[...rules.required, rules.maxLength(MAX_CHAR_LENGTH)]"
                     label="Mailing Address"
                   />
                 </v-col>
@@ -163,7 +163,7 @@
                     :disabled="isLocked"
                     variant="outlined"
                     required
-                    :rules="rules.required"
+                    :rules="[...rules.required, rules.maxLength(MAX_CHAR_LENGTH)]"
                     label="Organization Contact Name"
                   />
                 </v-col>
@@ -173,7 +173,7 @@
                     :disabled="isLocked"
                     variant="outlined"
                     required
-                    :rules="rules.required"
+                    :rules="[...rules.required, rules.maxLength(MAX_CHAR_LENGTH)]"
                     label="Position"
                   />
                 </v-col>
@@ -272,6 +272,8 @@ export default {
   },
   created() {
     this.PROVINCES = PROVINCES;
+    //ccfri 4269 - prevent certain text box values from getting cut off on summary decleration page
+    this.MAX_CHAR_LENGTH = 60;
     this.model.province1 = this.model.province1 ?? PROVINCES.find((province) => province.value === 'BC')?.value;
     this.model.province2 = this.model.province2 ?? PROVINCES.find((province) => province.value === 'BC')?.value;
   },
diff --git a/frontend/src/components/requestChanges/ReportChanges.vue b/frontend/src/components/requestChanges/ReportChanges.vue
index 4316496d..87eda191 100644
--- a/frontend/src/components/requestChanges/ReportChanges.vue
+++ b/frontend/src/components/requestChanges/ReportChanges.vue
@@ -103,7 +103,6 @@
           :height="maxChangeHistoryTableHeight"
           mobile-breakpoint="md"
           fixed-header
-          :item-class="getChangeRequestStyle"
           class="elevation-4 my-4"
           disable-pagination
           hide-default-footer
@@ -122,6 +121,11 @@
               </div>
             </v-tooltip>
           </template>
+          <template #item.externalStatus="{ item }">
+            <span :class="['tableText', getChangeRequestStyle(item.externalStatus)]">
+              {{ item.externalStatus }}
+            </span>
+          </template>
           <template #item.actions="{ item }">
             <v-btn
               v-if="isContinueButtonDisplayed(item.externalStatus)"
@@ -492,8 +496,8 @@ export default {
       }
       return '- - - -';
     },
-    getChangeRequestStyle(changeRequest) {
-      return changeRequest.externalStatus === 'Action Required' ? 'redText' : '';
+    getChangeRequestStyle(status) {
+      return status === 'Action Required' ? 'redText' : '';
     },
     next() {
       this.$router.push(PATHS.ROOT.HOME);
diff --git a/frontend/src/components/summary/group/OrganizationSummary.vue b/frontend/src/components/summary/group/OrganizationSummary.vue
index 2d94a84f..8bdc5b8c 100644
--- a/frontend/src/components/summary/group/OrganizationSummary.vue
+++ b/frontend/src/components/summary/group/OrganizationSummary.vue
@@ -32,7 +32,7 @@
             </v-col>
           </v-row>
           <v-row no-gutters>
-            <v-col cols="12" md="4">
+            <v-col cols="12" md="6">
               <div class="summary-label">Organization Mailing Address</div>
               <v-text-field
                 placeholder="Required"
@@ -47,7 +47,7 @@
               />
             </v-col>
             <template v-if="summaryModel.application.organizationProviderType === ORGANIZATION_PROVIDER_TYPES.GROUP">
-              <v-col cols="12" md="4">
+              <v-col cols="12" md="6">
                 <div class="summary-label">Organization Contact Name</div>
                 <v-text-field
                   placeholder="Required"
@@ -60,7 +60,7 @@
                   :rules="rules.required"
                 />
               </v-col>
-              <v-col cols="12" md="4">
+              <v-col cols="12" md="6">
                 <div class="summary-label">Position</div>
                 <v-text-field
                   placeholder="Required"

From 59d5425dffb64d45b9a2df520b63beba9d1e2944 Mon Sep 17 00:00:00 2001
From: Jen Beckett <115109120+jenbeckett@users.noreply.github.com>
Date: Thu, 19 Dec 2024 12:53:51 -0800
Subject: [PATCH 2/9] fix so name doesn't get cut off on family either

---
 .../components/summary/group/FacilityInformationSummary.vue   | 4 ++--
 frontend/src/components/summary/group/OrganizationSummary.vue | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/frontend/src/components/summary/group/FacilityInformationSummary.vue b/frontend/src/components/summary/group/FacilityInformationSummary.vue
index c2907770..a2bc3fdb 100644
--- a/frontend/src/components/summary/group/FacilityInformationSummary.vue
+++ b/frontend/src/components/summary/group/FacilityInformationSummary.vue
@@ -2,7 +2,7 @@
   <v-row no-gutters class="d-flex flex-column">
     <v-card class="facility-info pa-4 pb-2">
       <v-row no-gutters>
-        <v-col cols="12" md="6">
+        <v-col cols="12">
           <div class="summary-label">Facility Name</div>
           <v-textarea
             placeholder="Required"
@@ -372,7 +372,7 @@
       </v-expansion-panel-title>
       <v-expansion-panel-text eager class="exp-style">
         <v-row no-gutters>
-          <v-col cols="12" lg="6">
+          <v-col cols="12">
             <v-row no-gutters>
               <v-col cols="12">
                 <span class="summary-label"
diff --git a/frontend/src/components/summary/group/OrganizationSummary.vue b/frontend/src/components/summary/group/OrganizationSummary.vue
index 8bdc5b8c..b0cd6c85 100644
--- a/frontend/src/components/summary/group/OrganizationSummary.vue
+++ b/frontend/src/components/summary/group/OrganizationSummary.vue
@@ -32,7 +32,7 @@
             </v-col>
           </v-row>
           <v-row no-gutters>
-            <v-col cols="12" md="6">
+            <v-col cols="12">
               <div class="summary-label">Organization Mailing Address</div>
               <v-text-field
                 placeholder="Required"

From 07ce0815873c46bfb90e88fe0b07d2ae478f358a Mon Sep 17 00:00:00 2001
From: Jen Beckett <115109120+jenbeckett@users.noreply.github.com>
Date: Thu, 19 Dec 2024 13:17:09 -0800
Subject: [PATCH 3/9] final updates

---
 .../components/summary/group/FacilityInformationSummary.vue   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/summary/group/FacilityInformationSummary.vue b/frontend/src/components/summary/group/FacilityInformationSummary.vue
index a2bc3fdb..e71f5cac 100644
--- a/frontend/src/components/summary/group/FacilityInformationSummary.vue
+++ b/frontend/src/components/summary/group/FacilityInformationSummary.vue
@@ -112,7 +112,7 @@
       </v-expansion-panel-title>
       <v-expansion-panel-text eager class="exp-style">
         <v-row no-gutters>
-          <v-col cols="12" md="4" class="pr-2">
+          <v-col cols="12" md="8" class="pr-2">
             <div class="summary-label">
               Facility Name (as it appears on the Community Care Assisted Living Act Licence)
             </div>
@@ -130,7 +130,7 @@
               :rules="rules.required"
             />
           </v-col>
-          <v-col cols="12" md="4">
+          <v-col cols="12" md="2">
             <div class="summary-label">Year Facility Began Operation (YYYY)</div>
             <v-text-field
               placeholder="Required"

From 1146a77a55fde3897c17911339068c50d2c03209 Mon Sep 17 00:00:00 2001
From: Jen Beckett <115109120+jenbeckett@users.noreply.github.com>
Date: Thu, 19 Dec 2024 15:05:02 -0800
Subject: [PATCH 4/9] ccfri 4270 closed month checkboxes not loading correctly

---
 .../ccofApplication/family/FamilyFunding.vue  | 154 +++++++++++++-----
 .../ccofApplication/group/FundAmount.vue      | 154 +++++++++++++-----
 frontend/src/mixins/facilityMixin.js          |   1 -
 frontend/src/mixins/organizationMixin.js      |   2 -
 frontend/src/store/ccof/facility.js           |  21 ---
 frontend/src/store/ccof/funding.js            |   7 +-
 6 files changed, 229 insertions(+), 110 deletions(-)

diff --git a/frontend/src/components/ccofApplication/family/FamilyFunding.vue b/frontend/src/components/ccofApplication/family/FamilyFunding.vue
index 9e980f90..47b6b629 100644
--- a/frontend/src/components/ccofApplication/family/FamilyFunding.vue
+++ b/frontend/src/components/ccofApplication/family/FamilyFunding.vue
@@ -85,47 +85,121 @@
                   </v-col>
                 </v-row>
 
-                <v-row v-show="model.hasClosedMonth === 'yes'">
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn1" :disabled="isLocked" label="Jan" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn2" :disabled="isLocked" label="Feb" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn3" :disabled="isLocked" label="Mar" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn4" :disabled="isLocked" label="Apr" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn5" :disabled="isLocked" label="May" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn6" :disabled="isLocked" label="Jun" />
-                  </v-col>
-                </v-row>
+                <template v-if="model.hasClosedMonth === 'yes'">
+                  <v-row>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn1"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Jan"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn2"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Feb"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn3"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Mar"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn4"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Apr"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn5"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="May"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn6"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Jun"
+                      />
+                    </v-col>
+                  </v-row>
 
-                <v-row v-show="model.hasClosedMonth === 'yes'">
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn7" :disabled="isLocked" label="Jul" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn8" :disabled="isLocked" label="Aug" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn9" :disabled="isLocked" label="Sep" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn10" :disabled="isLocked" label="Oct" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn11" :disabled="isLocked" label="Nov" />
-                  </v-col>
-                  <v-col>
-                    <v-checkbox v-model="model.closedIn12" :disabled="isLocked" label="Dec" />
-                  </v-col>
-                </v-row>
+                  <v-row>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn7"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Jul"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn8"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Aug"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn9"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Sep"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn10"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Oct"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn11"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Nov"
+                      />
+                    </v-col>
+                    <v-col>
+                      <v-checkbox
+                        v-model="model.closedIn12"
+                        :true-value="1"
+                        :false-value="0"
+                        :disabled="isLocked"
+                        label="Dec"
+                      />
+                    </v-col>
+                  </v-row>
+                </template>
 
                 <v-row>
                   <v-col cols="12" md="6">
diff --git a/frontend/src/components/ccofApplication/group/FundAmount.vue b/frontend/src/components/ccofApplication/group/FundAmount.vue
index aed0afa7..849878a5 100644
--- a/frontend/src/components/ccofApplication/group/FundAmount.vue
+++ b/frontend/src/components/ccofApplication/group/FundAmount.vue
@@ -78,47 +78,121 @@
                 </v-col>
               </v-row>
 
-              <v-row v-show="model.hasClosedMonth === 'yes'">
-                <v-col>
-                  <v-checkbox v-model="model.closedIn1" :disabled="isLocked" label="Jan" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn2" :disabled="isLocked" label="Feb" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn3" :disabled="isLocked" label="Mar" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn4" :disabled="isLocked" label="Apr" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn5" :disabled="isLocked" label="May" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn6" :disabled="isLocked" label="Jun" />
-                </v-col>
-              </v-row>
+              <template v-if="model.hasClosedMonth === 'yes'">
+                <v-row>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn1"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Jan"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn2"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Feb"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn3"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Mar"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn4"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Apr"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn5"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="May"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn6"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Jun"
+                    />
+                  </v-col>
+                </v-row>
 
-              <v-row v-show="model.hasClosedMonth === 'yes'">
-                <v-col>
-                  <v-checkbox v-model="model.closedIn7" :disabled="isLocked" label="Jul" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn8" :disabled="isLocked" label="Aug" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn9" :disabled="isLocked" label="Sep" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn10" :disabled="isLocked" label="Oct" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn11" :disabled="isLocked" label="Nov" />
-                </v-col>
-                <v-col>
-                  <v-checkbox v-model="model.closedIn12" :disabled="isLocked" label="Dec" />
-                </v-col>
-              </v-row>
+                <v-row>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn7"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Jul"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn8"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Aug"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn9"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Sep"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn10"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Oct"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn11"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Nov"
+                    />
+                  </v-col>
+                  <v-col>
+                    <v-checkbox
+                      v-model="model.closedIn12"
+                      :true-value="1"
+                      :false-value="0"
+                      :disabled="isLocked"
+                      label="Dec"
+                    />
+                  </v-col>
+                </v-row>
+              </template>
             </v-container>
           </v-card>
 
diff --git a/frontend/src/mixins/facilityMixin.js b/frontend/src/mixins/facilityMixin.js
index abcc8646..4260f0ef 100644
--- a/frontend/src/mixins/facilityMixin.js
+++ b/frontend/src/mixins/facilityMixin.js
@@ -151,7 +151,6 @@ export default {
         baseFundingId = navBarStore.getNavByFacilityId(this.facilityId).ccofBaseFundingId;
       }
 
-      console.log('basefunding: ', baseFundingId);
       if (baseFundingId) {
         if (this.isChangeRequest) {
           this.$router.push(changeUrlGuid(PATHS.CCOF_GROUP_FUNDING, this.changeRequestId, baseFundingId));
diff --git a/frontend/src/mixins/organizationMixin.js b/frontend/src/mixins/organizationMixin.js
index 8a1aec68..d6b38ce8 100644
--- a/frontend/src/mixins/organizationMixin.js
+++ b/frontend/src/mixins/organizationMixin.js
@@ -39,11 +39,9 @@ export default {
     };
   },
   async mounted() {
-    console.log('org mounted called');
     this.businessId = this.userInfo.userName;
 
     if (this.isStarted) {
-      console.log('org mounted called2');
       this.model = { ...this.organizationModel };
       this.processing = false;
       this.loading = false;
diff --git a/frontend/src/store/ccof/facility.js b/frontend/src/store/ccof/facility.js
index c68faeba..909f10d5 100644
--- a/frontend/src/store/ccof/facility.js
+++ b/frontend/src/store/ccof/facility.js
@@ -35,19 +35,15 @@ export const useFacilityStore = defineStore('facility', {
     isValidForm(value) {
       this.isValidForm = value;
     },
-    // setFacilityList: (facilityList) => { this.facilityList = facilityList; },
-    // addToFacilityList: (payload) => { this.facilityList.push (payload); },
     setFacilityModel(facilityModel) {
       this.facilityModel = facilityModel;
     },
     setLoadedModel(model) {
       this.loadedModel = model;
     },
-    // setCCFRIFacilityModel: (CCFRIFacilityModel) => { this.CCFRIFacilityModel = CCFRIFacilityModel; }, //jb
     setFacilityId(facilityId) {
       this.facilityId = facilityId;
     },
-    // setCcfriId: (ccfriId) => { this.ccfriId = ccfriId; },
     addFacilityToStore({ facilityId, facilityModel }) {
       if (facilityId) {
         this.facilityStore[facilityId] = facilityModel;
@@ -56,11 +52,6 @@ export const useFacilityStore = defineStore('facility', {
     deleteFromStore(facilityId) {
       delete this.facilityStore[facilityId];
     },
-    // addCCFRIToStore: ({ccfriId, CCFRIFacilityModel} ) => {
-    //   if (ccfriId) {
-    //     this.ccfriStore[ccfriId] = CCFRIFacilityModel;
-    //   }
-    // }
     async saveFacility({ isChangeRequest, changeRequestId }) {
       checkSession();
       const applicationStore = useApplicationStore();
@@ -68,16 +59,12 @@ export const useFacilityStore = defineStore('facility', {
       const reportChangesStore = useReportChangesStore();
       const organizationStore = useOrganizationStore();
 
-      // console.log('saveFacility- state model: ', this.facilityModel);
-      // console.log('saveFacility- loaded model: ', this.loadedModel);
       if (isEqual(this.facilityModel, this.loadedModel)) {
-        console.info('no model changes');
         return;
       }
 
       let organizationId = organizationStore.organizationId;
       if (!organizationId) {
-        console.log('unable to save facility because you are not associated to an organization');
         throw 'unable to save facility because you are not associated to an organization';
       }
 
@@ -89,7 +76,6 @@ export const useFacilityStore = defineStore('facility', {
           this?.facilityModel?.postalCode?.replace(/\s/g, '').toUpperCase() ==
           this?.loadedModel?.postalCode?.replace(/\s/g, '').toUpperCase()
         ) {
-          console.info('no post code changes, do not save post code');
           delete payload.postalCode;
         } else {
           //format the post code nice for Dynamics
@@ -98,7 +84,6 @@ export const useFacilityStore = defineStore('facility', {
       } catch (e) {
         console.log(e);
       }
-      console.log(payload);
       this.setLoadedModel(this.facilityModel);
 
       if (this.facilityId) {
@@ -118,10 +103,8 @@ export const useFacilityStore = defineStore('facility', {
           throw error;
         }
       } else {
-        console.log('creating change request?', isChangeRequest);
         // else create a new facility.  If is a change request, hit the change request endpoint
         if (isChangeRequest) {
-          // console.log('changeRequestId: ', changeRequestId);
           try {
             let changeActionId;
             if (changeRequestId) {
@@ -133,7 +116,6 @@ export const useFacilityStore = defineStore('facility', {
                   (el) => el.changeRequestId == changeRequestId,
                 )?.changeActionId;
               }
-              console.log('Change ActionId is ', changeActionId);
             }
             if (!changeActionId) {
               const changeRequestPayload = {
@@ -141,7 +123,6 @@ export const useFacilityStore = defineStore('facility', {
                 programYearId: applicationStore.programYearId,
                 changeType: 'NEW_FACILITY',
               };
-              console.log('calling create change rec new fac');
               const changeRequestResponse = await ApiService.apiAxios.post(
                 ApiRoutes.CHANGE_REQUEST_NEW_FAC,
                 changeRequestPayload,
@@ -215,7 +196,6 @@ export const useFacilityStore = defineStore('facility', {
             throw error;
           }
         } else {
-          console.log('trying new facility');
           try {
             let response = await ApiService.apiAxios.post(ApiRoutes.FACILITY, payload);
             this.setFacilityId(response.data?.facilityId);
@@ -243,7 +223,6 @@ export const useFacilityStore = defineStore('facility', {
       this.setFacilityId(facilityId);
       let facilityModel = this.getFacilityById(facilityId);
       if (facilityModel) {
-        console.log('found facility for guid: ', facilityId);
         this.setFacilityModel(facilityModel);
         this.setLoadedModel(facilityModel);
       } else {
diff --git a/frontend/src/store/ccof/funding.js b/frontend/src/store/ccof/funding.js
index bdf83195..06633a81 100644
--- a/frontend/src/store/ccof/funding.js
+++ b/frontend/src/store/ccof/funding.js
@@ -1,5 +1,5 @@
-import { defineStore } from 'pinia';
 import { isEmpty, isEqual } from 'lodash';
+import { defineStore } from 'pinia';
 
 import ApiService from '../../common/apiService.js';
 import { ApiRoutes } from '../../utils/constants.js';
@@ -45,7 +45,6 @@ export const useFundingStore = defineStore('funding', {
       checkSession();
 
       if (isEqual(this.fundingModel, this.loadedModel)) {
-        console.info('no model changes');
         return;
       }
 
@@ -70,8 +69,6 @@ export const useFundingStore = defineStore('funding', {
       }
 
       deleteFields.forEach((field) => delete payload[field]);
-
-      console.log('save group funding', payload);
       let response = await ApiService.apiAxios.put(ApiRoutes.GROUP_FUND_AMOUNT + '/' + this.ccofBaseFundingId, payload);
       return response;
     },
@@ -79,7 +76,6 @@ export const useFundingStore = defineStore('funding', {
       this.setCcofBaseFundingId(fundingId);
       let model = this.getModelById(fundingId);
       if (model) {
-        console.log('found model for guid: ', fundingId);
         this.setFundingModel(model);
         this.setLoadedModel(model);
       } else {
@@ -90,7 +86,6 @@ export const useFundingStore = defineStore('funding', {
           if (model.familyLicenseType) {
             model.familyLicenseType = '' + model.familyLicenseType;
           }
-          console.log('response', model);
           this.setFundingModel(model);
           this.setLoadedModel(model);
           this.addModelToStore({ fundingId, model });

From 297e9ced45b2cd3dc243c0504a76f719a09d0591 Mon Sep 17 00:00:00 2001
From: Jen Beckett <115109120+jenbeckett@users.noreply.github.com>
Date: Fri, 20 Dec 2024 11:42:31 -0800
Subject: [PATCH 5/9] remove code smell and remove more logs

---
 frontend/src/mixins/facilityMixin.js |   1 -
 frontend/src/store/ccof/facility.js  | 214 +++++++++++++--------------
 frontend/src/store/navBar.js         |   3 +-
 3 files changed, 107 insertions(+), 111 deletions(-)

diff --git a/frontend/src/mixins/facilityMixin.js b/frontend/src/mixins/facilityMixin.js
index 4260f0ef..f571aeb2 100644
--- a/frontend/src/mixins/facilityMixin.js
+++ b/frontend/src/mixins/facilityMixin.js
@@ -134,7 +134,6 @@ export default {
       }
     },
     async next() {
-      // await this.save();
       if (!this.$route.params.urlGuid) {
         //we won't have the funding guid until we save, so save first.
         await this.save(false);
diff --git a/frontend/src/store/ccof/facility.js b/frontend/src/store/ccof/facility.js
index 909f10d5..cd204026 100644
--- a/frontend/src/store/ccof/facility.js
+++ b/frontend/src/store/ccof/facility.js
@@ -7,6 +7,7 @@ import { useFundingStore } from '@/store/ccof/funding.js';
 import { useOrganizationStore } from '@/store/ccof/organization.js';
 import { useNavBarStore } from '@/store/navBar.js';
 import { useReportChangesStore } from '@/store/reportChanges.js';
+import { CHANGE_REQUEST_TYPES } from '@/utils/constants';
 import { ApiRoutes, ORGANIZATION_PROVIDER_TYPES } from '@/utils/constants.js';
 import { checkSession } from '@/utils/session.js';
 
@@ -102,120 +103,117 @@ export const useFacilityStore = defineStore('facility', {
           console.log(`Failed to update existing Facility - ${error}`);
           throw error;
         }
-      } else {
-        // else create a new facility.  If is a change request, hit the change request endpoint
-        if (isChangeRequest) {
-          try {
-            let changeActionId;
-            if (changeRequestId) {
-              //If there is a changeRequestId, get the change action from the store.
-              changeActionId = reportChangesStore.changeActionId;
-              if (!changeActionId) {
-                //If there is no changeActionID, then maybe the user refreshed.  Get it from the navBar
-                changeActionId = navBarStore.navBarList.find(
-                  (el) => el.changeRequestId == changeRequestId,
-                )?.changeActionId;
-              }
-            }
+      } else if (isChangeRequest) {
+        try {
+          let changeActionId;
+          if (changeRequestId) {
+            //If there is a changeRequestId, get the change action from the store.
+            changeActionId = reportChangesStore.changeActionId;
             if (!changeActionId) {
-              const changeRequestPayload = {
-                applicationId: applicationStore.applicationId,
-                programYearId: applicationStore.programYearId,
-                changeType: 'NEW_FACILITY',
-              };
-              const changeRequestResponse = await ApiService.apiAxios.post(
-                ApiRoutes.CHANGE_REQUEST_NEW_FAC,
-                changeRequestPayload,
-              );
-              reportChangesStore.setChangeRequestId(changeRequestResponse.data?.changeRequestId);
-              reportChangesStore.setChangeActionId(changeRequestResponse.data?.changeActionId);
-              navBarStore.setChangeRequestId(changeRequestResponse.data?.changeRequestId);
-              const changeRequestNewFacilityModel = {
-                changeRequestId: changeRequestResponse.data?.changeRequestId,
-                agreeConsentCertify: null,
-                applicableSector: null,
-                applicationId: applicationStore.applicationId,
-                belongsToUnion: null,
-                changeActions: [
-                  {
-                    applicationStatus: 1,
-                    changeActionId: changeRequestResponse.data?.changeActionId,
-                    changeType: 100000005,
-                    isCCOFUnlocked: false,
-                    isChangeRequestUnlocked: false,
-                    isEceweUnlocked: false,
-                    isLicenseUploadUnlocked: false,
-                    isOtherDocumentsUnlocked: false,
-                    isSupportingDocumentsUnlocked: false,
-                    newFacilities: [],
-                  },
-                ],
-                confirmation: null,
-                enabledDeclarationB: false,
-                externalStatus: 'INCOMPLETE',
-                firstSubmissionDate: null,
-                fundingModel: null,
-                isChangeRequestUnlocked: false,
-                isEceweComplete: false,
-                isLicenseUploadComplete: false,
-                latestSubmissionDate: null,
-                optInECEWE: null,
-                orgContactName: null,
-                programYearId: applicationStore.programYearId,
-                providerType: ORGANIZATION_PROVIDER_TYPES.GROUP,
-                status: 1,
-                unlockDeclaration: false,
-              };
-              reportChangesStore.addNewChangeRequestToMap(changeRequestNewFacilityModel);
-              changeActionId = changeRequestResponse.data?.changeActionId;
+              //If there is no changeActionID, then maybe the user refreshed.  Get it from the navBar
+              changeActionId = navBarStore.navBarList.find(
+                (el) => el.changeRequestId == changeRequestId,
+              )?.changeActionId;
             }
-            let response = await ApiService.apiAxios.post(
-              `${ApiRoutes.CHANGE_REQUEST_NEW_FAC}/${changeActionId}`,
-              payload,
+          }
+          if (!changeActionId) {
+            const changeRequestPayload = {
+              applicationId: applicationStore.applicationId,
+              programYearId: applicationStore.programYearId,
+              changeType: 'NEW_FACILITY',
+            };
+            const changeRequestResponse = await ApiService.apiAxios.post(
+              ApiRoutes.CHANGE_REQUEST_NEW_FAC,
+              changeRequestPayload,
             );
-            this.setFacilityId(response.data?.facilityId);
-            const navBarPayload = {
-              facilityName: this.facilityModel.facilityName,
-              facilityId: this.facilityId,
-              ccofBaseFundingId: response.data?.ccofBaseFundingId,
-              ccofBaseFundingStatus: response.data?.ccofBaseFundingStatus,
-              licenseNumber: this.facilityModel.licenseNumber,
-              changeRequestId: reportChangesStore.changeRequestId,
-              changeActionId: reportChangesStore.changeActionId,
-              changeRequestNewFacilityId: response.data?.changeRequestNewFacilityId,
-              facilityStatus: 'New',
-              isCCOFComplete: false, //funding page must be complete to be true
+            reportChangesStore.setChangeRequestId(changeRequestResponse.data?.changeRequestId);
+            reportChangesStore.setChangeActionId(changeRequestResponse.data?.changeActionId);
+            navBarStore.setChangeRequestId(changeRequestResponse.data?.changeRequestId);
+            const changeRequestNewFacilityModel = {
+              changeRequestId: changeRequestResponse.data?.changeRequestId,
+              agreeConsentCertify: null,
+              applicableSector: null,
+              applicationId: applicationStore.applicationId,
+              belongsToUnion: null,
+              changeActions: [
+                {
+                  applicationStatus: 1,
+                  changeActionId: changeRequestResponse.data?.changeActionId,
+                  changeType: CHANGE_REQUEST_TYPES.NEW_FACILITY,
+                  isCCOFUnlocked: false,
+                  isChangeRequestUnlocked: false,
+                  isEceweUnlocked: false,
+                  isLicenseUploadUnlocked: false,
+                  isOtherDocumentsUnlocked: false,
+                  isSupportingDocumentsUnlocked: false,
+                  newFacilities: [],
+                },
+              ],
+              confirmation: null,
+              enabledDeclarationB: false,
+              externalStatus: 'INCOMPLETE',
+              firstSubmissionDate: null,
+              fundingModel: null,
+              isChangeRequestUnlocked: false,
+              isEceweComplete: false,
+              isLicenseUploadComplete: false,
+              latestSubmissionDate: null,
+              optInECEWE: null,
+              orgContactName: null,
+              programYearId: applicationStore.programYearId,
+              providerType: ORGANIZATION_PROVIDER_TYPES.GROUP,
+              status: 1,
+              unlockDeclaration: false,
             };
-            reportChangesStore.addNewFacilityDataToCRMap(navBarPayload);
-            navBarStore.addToNavBar(navBarPayload);
-            this.addFacilityToStore({ facilityId: response.data?.facilityId, facilityModel: this.facilityModel });
-
-            return response;
-          } catch (error) {
-            console.log(`Failed to save new Facility - ${error}`);
-            throw error;
+            reportChangesStore.addNewChangeRequestToMap(changeRequestNewFacilityModel);
+            changeActionId = changeRequestResponse.data?.changeActionId;
           }
-        } else {
-          try {
-            let response = await ApiService.apiAxios.post(ApiRoutes.FACILITY, payload);
-            this.setFacilityId(response.data?.facilityId);
-            const navBarPayload = {
-              facilityName: this.facilityModel.facilityName,
-              facilityId: this.facilityId,
-              ccofBaseFundingId: response.data?.ccofBaseFundingId,
-              ccofBaseFundingStatus: response.data?.ccofBaseFundingStatus,
-              licenseNumber: this.facilityModel.licenseNumber,
-              facilityStatus: 'New',
-              isCCOFComplete: false, //funding page must be complete to be true
-            };
-            navBarStore.addToNavBar(navBarPayload);
-            this.addFacilityToStore({ facilityId: response.data?.facilityId, facilityModel: this.facilityModel });
+          let response = await ApiService.apiAxios.post(
+            `${ApiRoutes.CHANGE_REQUEST_NEW_FAC}/${changeActionId}`,
+            payload,
+          );
+          this.setFacilityId(response.data?.facilityId);
+          const navBarPayload = {
+            facilityName: this.facilityModel.facilityName,
+            facilityId: this.facilityId,
+            ccofBaseFundingId: response.data?.ccofBaseFundingId,
+            ccofBaseFundingStatus: response.data?.ccofBaseFundingStatus,
+            licenseNumber: this.facilityModel.licenseNumber,
+            changeRequestId: reportChangesStore.changeRequestId,
+            changeActionId: reportChangesStore.changeActionId,
+            changeRequestNewFacilityId: response.data?.changeRequestNewFacilityId,
+            facilityStatus: 'New',
+            isCCOFComplete: false, //funding page must be complete to be true
+          };
+          reportChangesStore.addNewFacilityDataToCRMap(navBarPayload);
+          navBarStore.addToNavBar(navBarPayload);
+          this.addFacilityToStore({ facilityId: response.data?.facilityId, facilityModel: this.facilityModel });
 
-            return response;
-          } catch (error) {
-            console.log(`Failed to save new Facility - ${error}`);
-            throw error;
-          }
+          return response;
+        } catch (error) {
+          console.log(`Failed to save new Facility - ${error}`);
+          throw error;
+        }
+      } else {
+        try {
+          let response = await ApiService.apiAxios.post(ApiRoutes.FACILITY, payload);
+          this.setFacilityId(response.data?.facilityId);
+          const navBarPayload = {
+            facilityName: this.facilityModel.facilityName,
+            facilityId: this.facilityId,
+            ccofBaseFundingId: response.data?.ccofBaseFundingId,
+            ccofBaseFundingStatus: response.data?.ccofBaseFundingStatus,
+            licenseNumber: this.facilityModel.licenseNumber,
+            facilityStatus: 'New',
+            isCCOFComplete: false, //funding page must be complete to be true
+          };
+          navBarStore.addToNavBar(navBarPayload);
+          this.addFacilityToStore({ facilityId: response.data?.facilityId, facilityModel: this.facilityModel });
+
+          return response;
+        } catch (error) {
+          console.log(`Failed to save new Facility - ${error}`);
+          throw error;
         }
       }
     },
diff --git a/frontend/src/store/navBar.js b/frontend/src/store/navBar.js
index 209ae0df..b6e202b3 100644
--- a/frontend/src/store/navBar.js
+++ b/frontend/src/store/navBar.js
@@ -42,7 +42,6 @@ function getFacilityListFromNewFacilityCR(userProfileList, changeAction) {
     changeAction.newFacilities?.forEach((el) => {
       const facility = userProfileList.find((f) => f.facilityId === el.facilityId);
       if (facility) {
-        console.log(el.baseFunding?.ccofBaseFundingId);
         navBarFacilities.push({
           facilityId: facility.facilityId,
           facilityName: facility.facilityName,
@@ -196,7 +195,7 @@ export const useNavBarStore = defineStore('navBar', {
      * and reforce the navbar to refresh
      ************************************************/
     setNavBarValue({ facilityId, property, value }) {
-      console.log('set navBar called with value: ' + property + ' , ' + value);
+      //console.log('set navBar called with value: ' + property + ' , ' + value);
       let userProfileItem;
       if (this.changeType === 'mtfi') {
         userProfileItem = this.getChangeActionDetails('mtfi', 'ccfriFacilityId', facilityId);

From 282a75dfb193088cdc8b0d16098291d1b43d5bcd Mon Sep 17 00:00:00 2001
From: weskubo-cgi <Wesley.Kubo@gov.bc.ca>
Date: Mon, 23 Dec 2024 11:00:28 -0800
Subject: [PATCH 6/9] Removed console.log.

---
 frontend/src/components/LandingPage.vue | 1 -
 1 file changed, 1 deletion(-)

diff --git a/frontend/src/components/LandingPage.vue b/frontend/src/components/LandingPage.vue
index 2faac7fb..c76b1fcd 100644
--- a/frontend/src/components/LandingPage.vue
+++ b/frontend/src/components/LandingPage.vue
@@ -497,7 +497,6 @@ export default {
     },
     ccofRenewStatus() {
       if (this.applicationType === 'RENEW') {
-        console.log(this.applicationStatus);
         if (this.applicationStatus === 'DRAFT') {
           return this.RENEW_STATUS_CONTINUE;
         } else if (this.isWithinRenewDate) {

From 63cc524072411947889526bfc3c18aef3d351b2e Mon Sep 17 00:00:00 2001
From: Jen Beckett <115109120+jenbeckett@users.noreply.github.com>
Date: Mon, 23 Dec 2024 11:13:03 -0800
Subject: [PATCH 7/9] updates from Wes

---
 .../ccofApplication/group/OrganizationInformation.vue    | 9 ++++-----
 frontend/src/store/ccof/facility.js                      | 2 +-
 frontend/src/store/navBar.js                             | 1 -
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/frontend/src/components/ccofApplication/group/OrganizationInformation.vue b/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
index bb74e172..f27527f0 100644
--- a/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
+++ b/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
@@ -61,7 +61,7 @@
                     :disabled="isLocked"
                     variant="outlined"
                     required
-                    :rules="[...rules.required, rules.maxLength(MAX_CHAR_LENGTH)]"
+                    :rules="[...rules.required]"
                     label="Mailing Address"
                   />
                 </v-col>
@@ -163,7 +163,7 @@
                     :disabled="isLocked"
                     variant="outlined"
                     required
-                    :rules="[...rules.required, rules.maxLength(MAX_CHAR_LENGTH)]"
+                    :rules="[...rules.required]"
                     label="Organization Contact Name"
                   />
                 </v-col>
@@ -173,7 +173,7 @@
                     :disabled="isLocked"
                     variant="outlined"
                     required
-                    :rules="[...rules.required, rules.maxLength(MAX_CHAR_LENGTH)]"
+                    :rules="[...rules.required]"
                     label="Position"
                   />
                 </v-col>
@@ -272,8 +272,7 @@ export default {
   },
   created() {
     this.PROVINCES = PROVINCES;
-    //ccfri 4269 - prevent certain text box values from getting cut off on summary decleration page
-    this.MAX_CHAR_LENGTH = 60;
+
     this.model.province1 = this.model.province1 ?? PROVINCES.find((province) => province.value === 'BC')?.value;
     this.model.province2 = this.model.province2 ?? PROVINCES.find((province) => province.value === 'BC')?.value;
   },
diff --git a/frontend/src/store/ccof/facility.js b/frontend/src/store/ccof/facility.js
index cd204026..2137c10b 100644
--- a/frontend/src/store/ccof/facility.js
+++ b/frontend/src/store/ccof/facility.js
@@ -196,7 +196,7 @@ export const useFacilityStore = defineStore('facility', {
         }
       } else {
         try {
-          let response = await ApiService.apiAxios.post(ApiRoutes.FACILITY, payload);
+          const response = await ApiService.apiAxios.post(ApiRoutes.FACILITY, payload);
           this.setFacilityId(response.data?.facilityId);
           const navBarPayload = {
             facilityName: this.facilityModel.facilityName,
diff --git a/frontend/src/store/navBar.js b/frontend/src/store/navBar.js
index b6e202b3..ff0fb552 100644
--- a/frontend/src/store/navBar.js
+++ b/frontend/src/store/navBar.js
@@ -195,7 +195,6 @@ export const useNavBarStore = defineStore('navBar', {
      * and reforce the navbar to refresh
      ************************************************/
     setNavBarValue({ facilityId, property, value }) {
-      //console.log('set navBar called with value: ' + property + ' , ' + value);
       let userProfileItem;
       if (this.changeType === 'mtfi') {
         userProfileItem = this.getChangeActionDetails('mtfi', 'ccfriFacilityId', facilityId);

From 14361b7a11c81f7ed1ed2151d1f42715c589d7b2 Mon Sep 17 00:00:00 2001
From: Jen Beckett <115109120+jenbeckett@users.noreply.github.com>
Date: Mon, 23 Dec 2024 11:16:51 -0800
Subject: [PATCH 8/9] updates from Wes

---
 .../components/ccofApplication/group/OrganizationInformation.vue | 1 -
 1 file changed, 1 deletion(-)

diff --git a/frontend/src/components/ccofApplication/group/OrganizationInformation.vue b/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
index f27527f0..a559852a 100644
--- a/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
+++ b/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
@@ -272,7 +272,6 @@ export default {
   },
   created() {
     this.PROVINCES = PROVINCES;
-
     this.model.province1 = this.model.province1 ?? PROVINCES.find((province) => province.value === 'BC')?.value;
     this.model.province2 = this.model.province2 ?? PROVINCES.find((province) => province.value === 'BC')?.value;
   },

From 8510a05c3f60b681ad46ae1cdc2250fc307a14da Mon Sep 17 00:00:00 2001
From: Jen Beckett <115109120+jenbeckett@users.noreply.github.com>
Date: Mon, 23 Dec 2024 11:40:27 -0800
Subject: [PATCH 9/9] fixed the rules

---
 .../ccofApplication/group/OrganizationInformation.vue       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/frontend/src/components/ccofApplication/group/OrganizationInformation.vue b/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
index a559852a..c0b5f9cf 100644
--- a/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
+++ b/frontend/src/components/ccofApplication/group/OrganizationInformation.vue
@@ -61,7 +61,7 @@
                     :disabled="isLocked"
                     variant="outlined"
                     required
-                    :rules="[...rules.required]"
+                    :rules="rules.required"
                     label="Mailing Address"
                   />
                 </v-col>
@@ -163,7 +163,7 @@
                     :disabled="isLocked"
                     variant="outlined"
                     required
-                    :rules="[...rules.required]"
+                    :rules="rules.required"
                     label="Organization Contact Name"
                   />
                 </v-col>
@@ -173,7 +173,7 @@
                     :disabled="isLocked"
                     variant="outlined"
                     required
-                    :rules="[...rules.required]"
+                    :rules="rules.required"
                     label="Position"
                   />
                 </v-col>