Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharing jar indexing code #621

Open
johnynek opened this issue Feb 22, 2023 · 1 comment
Open

sharing jar indexing code #621

johnynek opened this issue Feb 22, 2023 · 1 comment

Comments

@johnynek
Copy link
Collaborator

this code creates a jar index here:

https://github.com/bazeltools/bazelfe/tree/main/bazelfe-core/src/jvm_indexer

but also this code creates indexes to build the dependency graph:

https://github.com/bazeltools/bzl-gen-build

bazelfe indexes predate the gen build tool. It seems like maybe we should remove indexing from this code and instead rely on bzl-gen-build indexes.

@ianoc
Copy link
Contributor

ianoc commented Feb 22, 2023

I think moving to use more or have the parser be a primary source or some hybrid will be an improvement due to its speed and ability to respond to refactoring. But things like protobufs, or external jars, or any genrule that happens to be about i guess bazelfe's indexer will respond to since it works on the jars and parses the target information out that way. Maybe some layered approach of trying to use the parsed info and falling back only then to what the sniffing of target building does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants