Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support toolchainzation in py_proto_library #1438

Closed
comius opened this issue Sep 29, 2023 · 3 comments · Fixed by #1933
Closed

feat: support toolchainzation in py_proto_library #1438

comius opened this issue Sep 29, 2023 · 3 comments · Fixed by #1933

Comments

@comius
Copy link
Contributor

comius commented Sep 29, 2023

See: bazelbuild/rules_proto#179
@comius comius self-assigned this Sep 29, 2023
@comius
Copy link
Contributor Author

comius commented Oct 5, 2023

cc @thesayyn

@comius comius removed their assignment Oct 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Apr 2, 2024
@aignas
Copy link
Collaborator

aignas commented Apr 2, 2024

@comius, @thesayyn, any update on this? Is this still WIP?

@github-actions github-actions bot removed the Can Close? Will close in 30 days if there is no new activity label Apr 3, 2024
@aignas aignas mentioned this issue Jun 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 5, 2024
@comius
feat: Upgrade to protobuf 27.0 and remove py_proto_library (#1933)
d0e25cf 
Protobuf team is taking ownership of `py_proto_library` and the
implementation was moved to protobuf repository.

Remove py_proto_library from rules_python, to prevent divergent
implementations.

Make a redirect with a deprecation warning, so that this doesn't break
any users.

Expected side effect of this change is also that the protobuf version is
sufficiently updated that there is no more use of legacy struct
providers.

Closes #1935 
Closes #1924 
Closes #1925 
Closes #1703 
Closes #1707 
Closes #1597 
Closes #1293 
Closes #1080
Fixes #1438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Upgrade to protobuf 27.0 and remove py_proto_library comius/rules_python
2 participants
@aignas @comius