Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple_framework copies .swiftmodule files into app bundle when used with dynamic vendored_xcframeworks #887

Open
vakhidbetrakhmadov opened this issue Aug 7, 2024 · 1 comment

Comments

@vakhidbetrakhmadov
Copy link
Contributor

Hi,

apple_framework copies .swiftmodule files into app bundle when used with dynamic vendored_xcframeworks.

This seems to be unnecessary.

This can be validate by running the following commands on latest master

$ bazelisk build //tests/ios/xcframeworks/Basic:XCFrameworksApp --apple_platform_type=ios
...
INFO: Build completed successfully, 1 total action
$ cp bazel-bin/tests/ios/xcframeworks/Basic/XCFrameworksApp.ipa XCFrameworksApp.zip
$ unzip -qq XCFrameworksApp.zip
find Payload/XCFrameworksApp.app -name '*.swiftmodule'
Payload/XCFrameworksApp.app/Frameworks/BasicXCFrameworkDynamic.framework/Modules/BasicXCFrameworkDynamic.swiftmodule

Furthermore when building with xcodebuild, .swiftmodule are never copied into app bundle.

This can be validate by building the following example project.

@vakhidbetrakhmadov
Copy link
Contributor Author

Just for reference, I was hoping that maybe apple_dynamic_xcframework_import doesn't have this issue, but it's the same:

bazelbuild/rules_apple#2510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant