From d6ad676abf33c28cc0771784927456b378e68d83 Mon Sep 17 00:00:00 2001
From: Luis Padron <lpadron@squareup.com>
Date: Tue, 7 Nov 2023 15:20:24 -0500
Subject: [PATCH] Support more valid ios_application kwargs (#803)

Adds support for `codesign_inputs`, `codesignopts` and `toolchains`
---
 rules/app.bzl             |  5 ++++-
 tests/ios/app/BUILD.bazel | 18 ++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/rules/app.bzl b/rules/app.bzl
index 6f6bc8cf3..11e748272 100644
--- a/rules/app.bzl
+++ b/rules/app.bzl
@@ -17,8 +17,10 @@ _IOS_APPLICATION_KWARGS = [
     "app_icons",
     "bundle_id",
     "bundle_name",
-    "entitlements",
+    "codesign_inputs",
+    "codesignopts",
     "entitlements_validation",
+    "entitlements",
     "env",
     "executable_name",
     "extensions",
@@ -36,6 +38,7 @@ _IOS_APPLICATION_KWARGS = [
     "strings",
     "tags",
     "test_host",
+    "toolchains",
     "version",
     "visibility",
 ]
diff --git a/tests/ios/app/BUILD.bazel b/tests/ios/app/BUILD.bazel
index aa649177b..d9ff17662 100644
--- a/tests/ios/app/BUILD.bazel
+++ b/tests/ios/app/BUILD.bazel
@@ -446,3 +446,21 @@ ios_application(
         "//tests/ios/frameworks/testonly:SwiftLibrary",
     ],
 )
+
+ios_application(
+    name = "AppWithDisabledCodesigning",
+    srcs = ["App/main.m"],
+    bundle_id = "com.example.app",
+    codesign_inputs = ["@build_bazel_rules_apple//tools/codesigningtool:disable_signing_resource_rules"],
+    codesignopts = [
+        "--digest-algorithm=sha1",
+        "--resource-rules=$(RESOURCE_RULES)",
+    ],
+    minimum_os_version = "10.0",
+    toolchains = ["@build_bazel_rules_apple//tools/codesigningtool:disable_signing_resource_rules"],
+    visibility = ["//visibility:public"],
+    deps = [
+        ":FW",
+        ":OnlySources",
+    ],
+)