You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As far as I can tell, there is no code which differentiates between AllowIgnored and AllowDirty... @sitaktif do you remember any history here? AFAICT there has never been any code which differentiates between these, or any tests which set --enforce-clean=allow-dirty (or indeed which set --enforce-clean=allow-ignored)?
#86 is going to simplify this behaviour to be more boolean (but doesn't remove the three variants) - I think this is ok (and that we should just remove the extra unused variant), but figured I should file an issue to discuss...
The text was updated successfully, but these errors were encountered:
Ouch, it does indeed look like I only implemented the --enforce-clean=allow-dirty path, and made --enforce-clean=allow-ignored act like --enforce-clean=allow-dirty.
I am happy to remove the allow-ignored state or maybe error out for now, so we can display something explanatory.
As far as I can tell, there is no code which differentiates between
AllowIgnored
andAllowDirty
... @sitaktif do you remember any history here? AFAICT there has never been any code which differentiates between these, or any tests which set--enforce-clean=allow-dirty
(or indeed which set--enforce-clean=allow-ignored
)?#86 is going to simplify this behaviour to be more boolean (but doesn't remove the three variants) - I think this is ok (and that we should just remove the extra unused variant), but figured I should file an issue to discuss...
The text was updated successfully, but these errors were encountered: