Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--enforce-clean accepts a tri-state value but only has boolean behaviour #87

Open
illicitonion opened this issue Apr 5, 2024 · 1 comment

Comments

@illicitonion
Copy link
Collaborator

As far as I can tell, there is no code which differentiates between AllowIgnored and AllowDirty... @sitaktif do you remember any history here? AFAICT there has never been any code which differentiates between these, or any tests which set --enforce-clean=allow-dirty (or indeed which set --enforce-clean=allow-ignored)?

#86 is going to simplify this behaviour to be more boolean (but doesn't remove the three variants) - I think this is ok (and that we should just remove the extra unused variant), but figured I should file an issue to discuss...

@sitaktif
Copy link
Collaborator

sitaktif commented Apr 8, 2024

Ouch, it does indeed look like I only implemented the --enforce-clean=allow-dirty path, and made --enforce-clean=allow-ignored act like --enforce-clean=allow-dirty.

I am happy to remove the allow-ignored state or maybe error out for now, so we can display something explanatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants