Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Allow BOM resolution with the Coursier resolver #1289

Open
srdo opened this issue Nov 26, 2024 · 0 comments · May be fixed by #1306
Open

Feature: Allow BOM resolution with the Coursier resolver #1289

srdo opened this issue Nov 26, 2024 · 0 comments · May be fixed by #1306

Comments

@srdo
Copy link

srdo commented Nov 26, 2024

Hi,

rules_jvm_external added support for Maven BOMs in #989 via the maven resolver.

Coursier has added support for specifying BOMs in their resolver as of 2.1.17 coursier/coursier#3143. It would be nice if rules_jvm_external allowed passing BOMs to Coursier using the same format as for the Maven resolver.
protocol7 added a commit to protocol7/rules_jvm_external that referenced this issue Jan 4, 2025
@protocol7
Add support for using Maven BOMs with Coursier
708af7d 
Coursier now support using Maven BOMs when resolving. This upgrades
Coursier to 2.1.23 and enables using BOMs leveraging the existing `boms`
attribute on `maven_install`.

Note that Coursier has a slight performance regression since adding
support for BOMs, see coursier/coursier#3190.

Fixes bazel-contrib#1289
@protocol7 protocol7 linked a pull request Jan 4, 2025 that will close this issue
Open
protocol7 added a commit to protocol7/rules_jvm_external that referenced this issue Jan 4, 2025
@protocol7
Add support for using Maven BOMs with Coursier
b22ec5e 
Coursier now support using Maven BOMs when resolving. This upgrades
Coursier to 2.1.23 and enables using BOMs leveraging the existing `boms`
attribute on `maven_install`.

Note that Coursier has a slight performance regression since adding
support for BOMs, see coursier/coursier#3190.

Fixes bazel-contrib#1289
protocol7 added a commit to protocol7/rules_jvm_external that referenced this issue Jan 18, 2025
@protocol7
Add support for using Maven BOMs with Coursier
41eb8f3 
Coursier now support using Maven BOMs when resolving. This upgrades
Coursier to 2.1.23 and enables using BOMs leveraging the existing `boms`
attribute on `maven_install`.

Note that Coursier has a slight performance regression since adding
support for BOMs, see coursier/coursier#3190.

Fixes bazel-contrib#1289
protocol7 added a commit to protocol7/rules_jvm_external that referenced this issue Jan 18, 2025
@protocol7
Add support for using Maven BOMs with Coursier
3df0c48 
Coursier now support using Maven BOMs when resolving. This upgrades
Coursier to 2.1.24 and enables using BOMs leveraging the existing `boms`
attribute on `maven_install`.

Note that Coursier has a slight performance regression since adding
support for BOMs, see coursier/coursier#3190.

Fixes bazel-contrib#1289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for using Maven BOMs with Coursier protocol7/rules_jvm_external
1 participant
@srdo