From 990d0c61437196493ead40bdb1b6f31524eeb202 Mon Sep 17 00:00:00 2001 From: Tristav <124001124+Pricstas@users.noreply.github.com> Date: Fri, 27 Dec 2024 15:58:25 +0100 Subject: [PATCH] Fix Typos and Update Links in Documentation (#1471) * typo 1_smart-wallet-spend-permissions.md * typos 1_verify-contract-with-basescan.md * typos 4_hardhat-test-coverage.md * Update link decomissioning-public-geth-archive-snapshots.md * Update link oracles.md --- .../notices/decomissioning-public-geth-archive-snapshots.md | 2 +- apps/base-docs/docs/tools/oracles.md | 2 +- .../tutorials/docs/1_smart-wallet-spend-permissions.md | 2 +- .../tutorials/docs/1_verify-contract-with-basescan.md | 4 ++-- apps/base-docs/tutorials/docs/4_hardhat-test-coverage.md | 6 +++--- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/apps/base-docs/docs/notices/decomissioning-public-geth-archive-snapshots.md b/apps/base-docs/docs/notices/decomissioning-public-geth-archive-snapshots.md index 5af3c8cf7b0..5875a52db4d 100644 --- a/apps/base-docs/docs/notices/decomissioning-public-geth-archive-snapshots.md +++ b/apps/base-docs/docs/notices/decomissioning-public-geth-archive-snapshots.md @@ -28,4 +28,4 @@ We recommend switching to Reth going forward. We will continue to maintain the R If you need continued Geth support, we would advise that you maintain your own snapshot that is specific to your infrastructure e.g. EBS on AWS. -If you have any questions or would like assistance, please reach out to us on [Discord](https://base.org/discord) or [GitHub](https://github.com/base-org/base-node). +If you have any questions or would like assistance, please reach out to us on [Discord](https://base.org/discord) or [GitHub](https://github.com/base-org/node). diff --git a/apps/base-docs/docs/tools/oracles.md b/apps/base-docs/docs/tools/oracles.md index affb144a7d7..03a3a07b391 100644 --- a/apps/base-docs/docs/tools/oracles.md +++ b/apps/base-docs/docs/tools/oracles.md @@ -173,7 +173,7 @@ See [this guide](https://docs.redstone.finance/) to learn how to use the RedSton [Supra](https://supraoracles.com) provides VRF and decentralized oracle price feeds that can be used for onchain and offchain use-cases such as spot and perpetual DEXes, lending protocols, and payments protocols. Supra’s oracle chain and consensus algorithm makes it one of the fastest-to-finality oracle providers, with layer-1 security guarantees. The pull oracle has a sub-second response time. Aside from speed and security, Supra’s rotating node architecture gathers data from 40+ data sources and applies a robust calculation methodology to get the most accurate value. The node provenance on the data dashboard also provides a fully transparent historical audit trail. Supra’s Distributed Oracle Agreement (DORA) paper was accepted into ICDCS 2023, the oldest distributed systems conference. -Visit the Supra [documentation](https://supraoracles.com/docs/) to learn more about integrating Supra's oracle and VRF into your Base project. +Visit the Supra [documentation](https://docs.supra.com) to learn more about integrating Supra's oracle and VRF into your Base project. #### Supported Networks diff --git a/apps/base-docs/tutorials/docs/1_smart-wallet-spend-permissions.md b/apps/base-docs/tutorials/docs/1_smart-wallet-spend-permissions.md index 42f8f3de073..4556ecc5a0a 100644 --- a/apps/base-docs/tutorials/docs/1_smart-wallet-spend-permissions.md +++ b/apps/base-docs/tutorials/docs/1_smart-wallet-spend-permissions.md @@ -114,7 +114,7 @@ Start by opening the `.env` file in the Healing Honey project and adding your pr SPENDER_PRIVATE_KEY=0xcd57753bb4e308ba0c6f574e8af04a7bae0ca0aff5750ddd6275460f49635527 ``` -Next, navigate to the `src/app/lib/spender.ts` file. Here, you'll see the `privateKeyToAccount` function from Viem in use. This function creates an wallet from the private key, enabling it to sign transactions and messages. The generated `account` is then used to create a [Wallet Client], which allows signing and executing onchain transactions to interact with the Spend Permission contract. +Next, navigate to the `src/app/lib/spender.ts` file. Here, you'll see the `privateKeyToAccount` function from Viem in use. This function creates a wallet from the private key, enabling it to sign transactions and messages. The generated `account` is then used to create a [Wallet Client], which allows signing and executing onchain transactions to interact with the Spend Permission contract. With your Spender Client set up, ensure all other required environment variables are configured for the app to work when running the dev server. diff --git a/apps/base-docs/tutorials/docs/1_verify-contract-with-basescan.md b/apps/base-docs/tutorials/docs/1_verify-contract-with-basescan.md index 0a66b4deff8..20fa09448fc 100644 --- a/apps/base-docs/tutorials/docs/1_verify-contract-with-basescan.md +++ b/apps/base-docs/tutorials/docs/1_verify-contract-with-basescan.md @@ -88,9 +88,9 @@ Once you have the private key to the wallet of your choice, open your terminal a export PRIVATE_KEY="" ``` -To deploy our contract you will need a RPC URL to a Base node in order to broadcast our transactions to the network. [CDP] provides us with a free node for interacting with Base mainnet and testnet. +To deploy our contract you will need an RPC URL to a Base node in order to broadcast our transactions to the network. [CDP] provides us with a free node for interacting with Base mainnet and testnet. -Obtain a rpc url from the [Node product] and store the url as an environment variable similar to the private key in the previous step. +Obtain an rpc url from the [Node product] and store the url as an environment variable similar to the private key in the previous step. ![cdp-node](../../assets/images/verify-with-basescan-api/cdp-node-full.png) diff --git a/apps/base-docs/tutorials/docs/4_hardhat-test-coverage.md b/apps/base-docs/tutorials/docs/4_hardhat-test-coverage.md index 6740ba2e0a0..f0fee67edde 100644 --- a/apps/base-docs/tutorials/docs/4_hardhat-test-coverage.md +++ b/apps/base-docs/tutorials/docs/4_hardhat-test-coverage.md @@ -154,7 +154,7 @@ describe("Lock Tests", function () { await expect(newInstanceUsingAnotherSigner.withdraw()).to.be.revertedWith("You aren't the owner") }) - it('should allow to withdraw a owner', async()=> { + it('should allow to withdraw an owner', async()=> { const balanceBefore = await ethers.provider.getBalance(await lockInstance.getAddress()); expect(balanceBefore).to.equal(VALUE_LOCKED) @@ -180,7 +180,7 @@ If you run `npx hardhat coverage`, you should get: ✔ should have the right owner ✔ shouldn't allow to withdraw before unlock time ✔ shouldn't allow to withdraw a non owner - ✔ should allow to withdraw a owner + ✔ should allow to withdraw an owner 6 passing (195ms) @@ -232,7 +232,7 @@ Then, run `npx hardhat coverage` and you should get: ✔ should have the right owner ✔ shouldn't allow to withdraw before unlock time ✔ shouldn't allow to withdraw a non owner - ✔ should allow to withdraw a owner + ✔ should allow to withdraw an owner 7 passing (198ms)