From ee2ad0ad6eeb691c4d9d5f10baa2a9eae0dbe334 Mon Sep 17 00:00:00 2001 From: savvasmoke <136869149+savvar9991@users.noreply.github.com> Date: Wed, 27 Nov 2024 16:49:54 +1100 Subject: [PATCH 1/5] Fixed syntax Vetoer1of2.sol MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixed a typo "Counter Party" → "Counterparty". Fixed a typo "Unhautorized" → "Unauthorized". Fixed syntax of the function of Address.functionCall (). --- src/Vetoer1of2.sol | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Vetoer1of2.sol b/src/Vetoer1of2.sol index 3b9ed38..b51a2de 100644 --- a/src/Vetoer1of2.sol +++ b/src/Vetoer1of2.sol @@ -21,7 +21,7 @@ contract Vetoer1of2 { /// @notice The address of Optimism's signer (likely a multisig) address public immutable opSigner; - /// @notice The address of counter party's signer (likely a multisig) + /// @notice The address of counterparty's signer (likely a multisig) address public immutable otherSigner; /// @notice The address of the DelayedVetoable contract. @@ -53,7 +53,7 @@ contract Vetoer1of2 { /// @notice Thrown at deployment if `target` is the zero address. error TargetCantBeZeroAddress(); - /// @notice Thrown when calling 'veto()' from an unhautorized signer. + /// @notice Thrown when calling 'veto()' from an unhauthorized signer. error SenderIsNotWhitelistedSigner(); ////////////////////////////////////////////////////////////// @@ -72,7 +72,7 @@ contract Vetoer1of2 { /// @custom:reverts TargetCantBeZeroAddress() if `target` is the zero address. /// /// @param opSigner_ Address of Optimism signer. - /// @param otherSigner_ Address of counter party signer. + /// @param otherSigner_ Address of counterparty signer. /// @param initiator Address of the initiator. /// @param target Address of the target. constructor(address opSigner_, address otherSigner_, address initiator, address target) { @@ -117,11 +117,11 @@ contract Vetoer1of2 { revert SenderIsNotWhitelistedSigner(); } - bytes memory result = Address.functionCall({ + bytes memory result = Address.functionCall( target: delayedVetoable, data: msg.data, errorMessage: "Vetoer1of2: failed to execute" - }); + ); emit VetoCallExecuted({caller: msg.sender, result: result}); } From 7de22efb5b533bf10e252d93995d65590b81a161 Mon Sep 17 00:00:00 2001 From: savvasmoke <136869149+savvar9991@users.noreply.github.com> Date: Wed, 27 Nov 2024 17:19:10 +1100 Subject: [PATCH 2/5] correst typo README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index f657f9e..8c78ec6 100644 --- a/README.md +++ b/README.md @@ -27,7 +27,7 @@ For contract deployment artifacts, see [base-org/contract-deployments](https://g [![GitHub pull requests by-label](https://img.shields.io/github/issues-pr-raw/base-org/contracts)](https://github.com/base-org/contracts/pulls) [![GitHub Issues](https://img.shields.io/github/issues-raw/base-org/contracts.svg)](https://github.com/base-org/contracts/issues) -### setup and testing +### Setup and Testing - If you don't have foundry installed, run `make install-foundry`. - Copy `.env.example` to `.env` and fill in the variables. From 5e91ded2bae4b607884b6d3ebdb3a743d9b37b03 Mon Sep 17 00:00:00 2001 From: savvasmoke <136869149+savvar9991@users.noreply.github.com> Date: Wed, 27 Nov 2024 17:28:38 +1100 Subject: [PATCH 3/5] correct SECURITY.md Replaced "Cover" with "Include" for greater accuracy. He removed excess commas and improved readability. He reformulated "Assurn" in "Ensurg" to improve grammar. Small stylistic improvements for better sound sound. --- SECURITY.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/SECURITY.md b/SECURITY.md index be49f19..d887730 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -5,9 +5,9 @@ In line with our strategy of being the safest way for users to access crypto: + Coinbase is extending our [best-in-industry][1] million-dollar [HackerOne bug bounty program][2] -to cover the Base network, the Base bridge contracts, and Base infrastructure. +to include the Base network, the Base bridge contracts, and Base infrastructure. -+ Coinbase's bug bounty program runs alongside Optimism's existing [Immunefi Bedrock bounty program][4] ++ Coinbases bug bounty program runs alongside Optimism's existing [Immunefi Bedrock bounty program][4] to support the open source [Bedrock][5] OP Stack framework. ## Reporting vulnerabilities @@ -16,9 +16,9 @@ All potential vulnerability reports can be submitted via the [HackerOne][6] platform. The HackerOne platform allows us to have a centralized and single reporting -source for us to deliver optimized SLA's and results. All reports submitted to +source, enabling us to deliver optimized SLA's and results. All reports submitted to the platform are triaged around the clock by our team of Coinbase engineers -with domain knowledge, assuring the best quality of review. +with domain knowledge, ensuring the best quality of review. For more information on reporting vulnerabilities and our HackerOne bug bounty program, view our [security program policies][7]. From 52b5e46301057b0539863f4f7c513c04ae75e9c5 Mon Sep 17 00:00:00 2001 From: savvasmoke <136869149+savvar9991@users.noreply.github.com> Date: Wed, 27 Nov 2024 17:32:44 +1100 Subject: [PATCH 4/5] correct foundry.toml fix --- foundry.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/foundry.toml b/foundry.toml index 10799e9..e950059 100644 --- a/foundry.toml +++ b/foundry.toml @@ -1,8 +1,8 @@ [profile.default] libs = ['lib'] -fs_permissions = [ {access = "read-write", path = "./"} ] +fs_permissions = [{access = "read-write", path = "./"}] optimizer = true optimizer_runs = 999999 solc_version = "0.8.15" -# See more config options https://github.com/foundry-rs/foundry/tree/master/config \ No newline at end of file +# See more config options https://github.com/foundry-rs/foundry/tree/master/config From 7e63ae3c7eb24b7c094d90bad4808ee868fbb291 Mon Sep 17 00:00:00 2001 From: savvasmoke <136869149+savvar9991@users.noreply.github.com> Date: Wed, 27 Nov 2024 17:34:52 +1100 Subject: [PATCH 5/5] fix remappings.txt In some configuration formats, it is recommended to add gaps before and after the sign of equality to improve readability --- remappings.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/remappings.txt b/remappings.txt index 5af5102..b695b42 100644 --- a/remappings.txt +++ b/remappings.txt @@ -1,5 +1,5 @@ -@eth-optimism-bedrock/=lib/optimism/packages/contracts-bedrock/ -@openzeppelin/contracts/=lib/openzeppelin-contracts/contracts -@openzeppelin/contracts-upgradeable/=lib/openzeppelin-contracts-upgradeable/contracts -@rari-capital/solmate/=lib/solmate/ -@solady/=lib/solady/src/ +@eth-optimism-bedrock/ = lib/optimism/packages/contracts-bedrock/ +@openzeppelin/contracts/ = lib/openzeppelin-contracts/contracts +@openzeppelin/contracts-upgradeable/ = lib/openzeppelin-contracts-upgradeable/contracts +@rari-capital/solmate/ = lib/solmate/ +@solady/ = lib/solady/src/