Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter Naming #99

Open
Rufusemmanuel opened this issue Oct 22, 2024 · 0 comments
Open

Parameter Naming #99

Rufusemmanuel opened this issue Oct 22, 2024 · 0 comments

Comments

@Rufusemmanuel
Copy link

The name of the parameter for the ERC721 token should reflect its purpose. In the createOptimismMintableERC721 function, you passed _l1erc721 but used "L1T721" as the symbol. It may be clearer to use "L2T721" for consistency.
0xObsidian added a commit to 0xObsidian/contracts_base that referenced this issue Dec 3, 2024
@0xObsidian
fix: align token symbol with parameter naming
b463b16 
This pr is to address issue base-org#99

Description
-----------
The `_l1erc721` parameter in createOptimismMintableERC721
represents the L1 token, while `L1T721` was incorrectly
used as the L2 token's symbol. Changed to `L2T721` to
properly reflect the relationship between the parameter
and the created token.
@0xObsidian 0xObsidian mentioned this issue Dec 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rufusemmanuel