Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the visualisation script #1

Open
johnlees opened this issue Aug 4, 2022 · 1 comment
Open

Split the visualisation script #1

johnlees opened this issue Aug 4, 2022 · 1 comment
Labels
enhancement New feature or request package

Comments

@johnlees
Copy link
Member

johnlees commented Aug 4, 2022

Cytoscape and microreact/grapetree/phandango use quite different paths. I think a better interface would be splitting this into two commands:

poppunk_visualise_tree
poppunk_visualise_network

Where the first makes all three outputs, the second does cytoscape. The network command may more naturally be part of the upcoming network package.

Would need to work out exactly where MST should fit into these (as it's kind of both).

@johnlees johnlees added enhancement New feature or request package labels Aug 4, 2022
@johnlees johnlees transferred this issue from bacpop/PopPUNK Aug 4, 2022
@johnlees
Copy link
Member Author

johnlees commented Aug 4, 2022

Specifically, this package should do the visualisation for MST and cytoscape poppunk_visualise_network, and PopPUNK should do trees/microreact poppunk_visualise_tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package
Projects
None yet
Development

No branches or pull requests

1 participant