[UX] Improve settings for simplified login page

[jenlampton]

Description of the bug

This is a follow-up to #6799 which was a follow-up to #6570.

1. we would like to add a checkbox to the Appearance page to enable the simplified login page for the admin theme.

In accordance with our "put the setting everywhere people might expect to find it" policy, we should duplicate the setting for Use the administration theme for simplified login pages by also placing this checkbox on the Appearance page.

2. Including "simplified login page" in radio buttons with "Use tabs" and "Use tabs" is probably not the best UI to ask and answer this question.

This is the current UI on the "Login settings" page

Login page options does not adequately describe the question we would like to have answered. Under this label, we have three options that do not answer the same question. I would like to propose another UI pattern for these options, as follows:

• A single checkbox for Simplify login pages as follows

  • Label: Use simplified login pages
  • Description: Simplified login pages hide all layout regions such as headers, footers, and sidebars.
  • when checked, does three things
  1. disables the "tabs" option for the Navigation question
  2. and sets the value for the Navigation question to links
  3. Reveals the Use the administration theme for simplified login pages checkbox

• A set of radio options as follows:

  • Label: Navigation between login pages
  • Description: Login pages include "Create new account", "Log in", and "Reset password" pages.
  • Options:
    • Links below the form
    • Tabs above the form (not available with simplified login pages)

[docwilmot]

I saw this issue coming a mile away!

[jenlampton]

Iterating:

[jenlampton]

Thinking about this more -- why is there even an option to choose "Tabs"? Is there a use-case for someone with a new install choosing tabs?

I thought this setting was something we were including only for backwards compatibility, and if that's the case, there doesn't need to be an option for it at all. Let me see what that might look like....

edit: I tried this, but I ended up not liking it very much. Posting a screenshot here in case others feel differently.

[jenlampton]

This is where I am stopping for now on the admin/config/people/login page. I'm going to switch to the Appearence page and wait for feedback so I don't end up going in circles by myself :)

[argiepiano]

The problem with this last screenshot is that, if you choose "simplified" appearance, you really should not be able to select navigation between login pages. The simplified look uses only links. I don't think anyone intended for tabs to be used there.

EDIT: I realize that you have a parenthesis that explains this, but this seems very wordy (and I missed it at first sight). I like what we currently have there, which was the result of a lot of discussion: the three options (tabs, links, simplified) are presented at an equal level, with the theme question only appearing when you select simplified.

[jenlampton]

The problem with this last screenshot is that, if you choose "simplified" appearance, you really should not be able to select navigation between login pages.

Yes, exactly -- the form adjusts so that the value is changed to "Links" -- which is what you get with Simplified. I added the note on tabs about that option not being available -- but I am open to other suggestions on how to make that more clear. I don't love this

[jenlampton]

the three options (tabs, links, simplified) are presented at an equal level,

This is the problem with the current form though, these should not be at the same level, because the user is not choosing between three options.

They are choosing: 1) Simplified or not?

And if not: 2) Tabs or Links?

How do we show that clearly in the UI?

Edit: maybe I just answered this for myself.... two sets of radio buttons?

[jenlampton]

okay Here's another go... thank you for helping me work through this :)

With standard pages selected:

With simplified pages selected:

[stpaultim]

@jenlampton I think your UI suggestions are good and do make the form a bit easier to understand.

The only thing I have a slight reservation about is "Page Complexity". It's accurate, but feels a bit awkward to me. Possible options:

1. Do we need that label at all? Doesn't "Login page display" set the stage enough. Standard login page display or Simplified login page display. I think it would work by just removing "Page complexity," as I'm not sure it adds anything to the page.

2. If we need or want to keep it, Could it simply be "Appearance" or "Display option"?

3. Stick with "Page complexity". It's not a dealbreaker.

[avpaderno]

I would use Style instead of Page Complexity, but I also think it is not necessary to add a title there.

[jenlampton]

Do we need that label at all?

We need a label for accessibility. (We cannot have any form element without a label.)

I would use Style instead of Page Complexity

"Style" is also accurate, but that word has so many other meanings unrelated to Layouts, hmm...

I ended up going with Regions and branding (but this could use feedback!)

And here's a PR for testing so you can see how it feels:
backdrop/backdrop#4986

[jenlampton]

I've also added the checkbox to the theme settings page.
The description on that chackbox only appears if the user has permission to visit the login settings page (since that permission is separate from this page).

[indigoxela]

I can see, there's good progress here, but currently UserLoginAppearanceTestCase fails - it needs to get updated according to the new form element structure.

And we'd probably need test coverage for changing the theme in system_themes_admin_form().

[indigoxela]

I just tested changing the theme via admin/appearance and it doesn't work. Only after flushing all caches manually (via admin bar) the changed setting takes effect.
I've added a PR comment.

Personally, I'm no fan of having that setting also on the themes page. But if there's consensus that this is a good idea... 🤷

[herbdool]

Regarding login page settings:

• How about "Login style" rather than the wordier "Regions and branding"?
• Since the "simplified" login is default on new installations, I don't think the non-simplified should be called "Standard". It's no longer the standard.