Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore padding index in negative log likelihood (NLL) loss #90

Open
ayushkarnawat opened this issue Mar 24, 2020 · 0 comments
Open

Ignore padding index in negative log likelihood (NLL) loss #90

ayushkarnawat opened this issue Mar 24, 2020 · 0 comments
Assignees
@ayushkarnawat
Labels
invalid This doesn't seem right

Comments

@ayushkarnawat
Copy link
Owner

Currently, the NLL loss computation doesn't take into account loss calculated as part of the padding index. These indices need to be ignored to more accurately measure the loss, so that the function optimizes properly.

For now, this doesn't matter since all the sequences are of the same length, meaning no padding is currently being used.
@ayushkarnawat ayushkarnawat added the invalid This doesn't seem right label Mar 24, 2020
@ayushkarnawat ayushkarnawat self-assigned this Mar 24, 2020
@ayushkarnawat ayushkarnawat changed the title Ignore index in negative log likelihood (NLL) loss Ignore padding index in negative log likelihood (NLL) loss Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayushkarnawat ayushkarnawat

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ayushkarnawat