From 2521ddcc48f23fecdd7342685c414028f703bd78 Mon Sep 17 00:00:00 2001 From: yanziseeker <153156292+AdventureSeeker987@users.noreply.github.com> Date: Wed, 24 Apr 2024 21:40:09 +0800 Subject: [PATCH 1/5] Update mod.rs --- halo2-ecc/src/ecc/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/halo2-ecc/src/ecc/mod.rs b/halo2-ecc/src/ecc/mod.rs index 65cec232..703a4305 100644 --- a/halo2-ecc/src/ecc/mod.rs +++ b/halo2-ecc/src/ecc/mod.rs @@ -1090,7 +1090,7 @@ where if radix == 0 { radix = 1; }*/ - // guessing that is is always better to use parallelism for >25 points + // guessing that is always better to use parallelism for >25 points pippenger::multi_exp_par::( self.field_chip, builder, From d676c614fd23d0ad717362b8c742c1991458e862 Mon Sep 17 00:00:00 2001 From: yanziseeker <153156292+AdventureSeeker987@users.noreply.github.com> Date: Wed, 24 Apr 2024 21:54:00 +0800 Subject: [PATCH 2/5] Update mod.rs --- halo2-base/src/poseidon/hasher/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/halo2-base/src/poseidon/hasher/mod.rs b/halo2-base/src/poseidon/hasher/mod.rs index 68cf64c6..035862d5 100644 --- a/halo2-base/src/poseidon/hasher/mod.rs +++ b/halo2-base/src/poseidon/hasher/mod.rs @@ -243,7 +243,7 @@ impl PoseidonHasher Date: Wed, 24 Apr 2024 21:55:08 +0800 Subject: [PATCH 3/5] Update fixed_base.rs --- halo2-ecc/src/ecc/fixed_base.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/halo2-ecc/src/ecc/fixed_base.rs b/halo2-ecc/src/ecc/fixed_base.rs index 304cd6b8..936b0efb 100644 --- a/halo2-ecc/src/ecc/fixed_base.rs +++ b/halo2-ecc/src/ecc/fixed_base.rs @@ -208,7 +208,7 @@ where }, ); let ctx = builder.main(); - // sum `scalar_mults` but take into account possiblity of identity points + // sum `scalar_mults` but take into account possibility of identity points let any_point2 = chip.load_random_point::(ctx); let mut acc = any_point2.clone(); for point in scalar_mults { From eae80f2160028634f7c02cb92765541945188314 Mon Sep 17 00:00:00 2001 From: yanziseeker <153156292+AdventureSeeker987@users.noreply.github.com> Date: Wed, 24 Apr 2024 21:55:39 +0800 Subject: [PATCH 4/5] Update mod.rs --- halo2-base/src/utils/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/halo2-base/src/utils/mod.rs b/halo2-base/src/utils/mod.rs index 2aaa5166..87404349 100644 --- a/halo2-base/src/utils/mod.rs +++ b/halo2-base/src/utils/mod.rs @@ -62,7 +62,7 @@ pub trait ScalarField: PrimeField + FromUniformBytes<64> + From + Hash + O /// Creates a field element from a little endian byte representation. /// /// The default implementation assumes that `PrimeField::from_repr` is implemented for little-endian. - /// It should be overriden if this is not the case. + /// It should be overridden if this is not the case. fn from_bytes_le(bytes: &[u8]) -> Self { let mut repr = Self::Repr::default(); repr.as_mut()[..bytes.len()].copy_from_slice(bytes); From 8922586688beaa2300da1ea3382be3a64d93ac47 Mon Sep 17 00:00:00 2001 From: yanziseeker <153156292+AdventureSeeker987@users.noreply.github.com> Date: Wed, 24 Apr 2024 21:57:57 +0800 Subject: [PATCH 5/5] Update bytes.rs --- halo2-base/src/safe_types/tests/bytes.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/halo2-base/src/safe_types/tests/bytes.rs b/halo2-base/src/safe_types/tests/bytes.rs index 9c24444f..2e58ddc4 100644 --- a/halo2-base/src/safe_types/tests/bytes.rs +++ b/halo2-base/src/safe_types/tests/bytes.rs @@ -16,7 +16,7 @@ use rand::rngs::OsRng; use std::vec; use test_case::test_case; -// =========== Utilies =============== +// =========== Utilities =============== fn mock_circuit_test, SafeTypeChip<'_, Fr>)>(mut f: FM) { base_test().k(10).lookup_bits(8).run(|ctx, range| { let safe = SafeTypeChip::new(range);