Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish rollout of codegen-based waiters #2977

Closed
lucix-aws opened this issue Jan 21, 2025 · 3 comments · Fixed by #2994
Closed

finish rollout of codegen-based waiters #2977

lucix-aws opened this issue Jan 21, 2025 · 3 comments · Fixed by #2994
Assignees
@lucix-aws
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@lucix-aws
Copy link
Contributor

lucix-aws commented Jan 21, 2025 •
edited
Loading

We recently introduced code-generated waiter support. We've since rolled out the feature in the EC2 service and have not received any reports of regressions from customers.

We should complete the rollout of generated waiters, as this will allow us to drop our dependency on go-jmespath.
@lucix-aws lucix-aws added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Jan 21, 2025
@Madrigal
Copy link
Contributor

EC2 has one of the most complex waiters. If we can do a manual test for it, we can probably be good for the rest of the waiters

@lucix-aws
Copy link
Contributor Author

https://github.com/aws/aws-sdk-go-v2/blob/main/codegen/sdk-codegen/aws-models/auto-scaling.json#L4202

@lucix-aws lucix-aws mentioned this issue Jan 23, 2025
Closed
@lucix-aws lucix-aws removed the queued This issues is on the AWS team's backlog label Jan 27, 2025
@lucix-aws lucix-aws self-assigned this Jan 27, 2025
@lucix-aws lucix-aws mentioned this issue Jan 30, 2025
Merged
@github-actions GitHub Actions
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucix-aws lucix-aws

Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch to code-generated waiters for remaining services aws/aws-sdk-go-v2
2 participants
@Madrigal @lucix-aws