From b4e1ec6a99c36d0c26c45f317b6a97630ecff8f1 Mon Sep 17 00:00:00 2001 From: Amedeo Sapio Date: Fri, 22 Mar 2024 03:26:00 +0000 Subject: [PATCH] rdma: removed SAS ordering requirement There is no case in which not having Send-After-Send ordering causes issues, so it is safe to remove it. The only possible reordering that can happen is if a ctrl message is received before a connect response message, but we already deal with this case correctly, since the control message is added to the msgbuf and retrieved when isend is called. Signed-off-by: Amedeo Sapio --- src/nccl_ofi_rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nccl_ofi_rdma.c b/src/nccl_ofi_rdma.c index 3b51d5602..de9019249 100644 --- a/src/nccl_ofi_rdma.c +++ b/src/nccl_ofi_rdma.c @@ -5743,8 +5743,8 @@ static void get_hints(struct fi_info *hints) hints->mode = 0; - hints->tx_attr->msg_order = FI_ORDER_SAS; - hints->rx_attr->msg_order = FI_ORDER_SAS; + hints->tx_attr->msg_order = FI_ORDER_NONE; + hints->rx_attr->msg_order = FI_ORDER_NONE; hints->ep_attr->type = FI_EP_RDM;