Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quality check to ensure signal.signal is only used in one place #111

Open
rafidka opened this issue Jul 5, 2024 · 0 comments
Open

Comments

@rafidka
Copy link
Contributor

rafidka commented Jul 5, 2024

Overview

The Python's method signal.signal can only be used to assign one signal handler, and if you call it again, it will remove the previous handler. Considering our reliance on this method in the subprocess module to handle SIGTERMs and gracefully shutdown processes, we need to make sure it is not accidentally called somewhere else, as that will break our logic.

Acceptance Criteria

  • Implement a quality check like the one for pip that scans our code and ensure the signal.signal method is only called in one place in the subprocess module.

Additional Info

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant