Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does gale handle dagger version differences when used via the dagger CLI? #84

Closed
gerhard opened this issue Aug 18, 2023 · 2 comments

Comments

@gerhard
Copy link

gerhard commented Aug 18, 2023

When gale is run via the dagger CLI, how does it ensure compatibility with the Engine that dagger manages?

As you know, when a command is run via dagger run <YOUR_COMMAND HERE>, the dagger CLI provisions the Engine. So if I have dagger v0.8.4 running locally which provisions Engine v0.8.4, but gale v0.0.4 expects v0.8.1, could this cause issues?


🙇‍♂️ For the dagger run gif size issue, have you tried dagger run --progress plain ? cc @vito for more terminal recording & sharing tips.

@aweris
Copy link
Owner

aweris commented Aug 18, 2023

🙇‍♂️ For the dagger run gif size issue, have you tried dagger run --progress plain ? cc @vito for more terminal recording & sharing tips.

Found the issue. terminalizer automatically gets screen size. If I don't drop my resolution to a minimum or adjust the screen size, it tries to generate bigger images. Adjusting the resolution helped a lot.

@aweris
Copy link
Owner

aweris commented Nov 8, 2023

With new module structure, no need to handle this issue specifically

@aweris aweris closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants