Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfernet dependencies fix #11

Open
gburzynski-10clouds opened this issue Jan 29, 2024 · 3 comments
Open

rfernet dependencies fix #11

gburzynski-10clouds opened this issue Jan 29, 2024 · 3 comments

Comments

@gburzynski-10clouds
Copy link
Contributor

My rfernet installation failed due to missing once_cell = "1.17.0" dependency in Cargo.toml.
I also needed to bump maturin to 1.4.0 because of regression in version 1.2.0.
I'll be happy to provide PR with fixes 👍
@gburzynski-10clouds
Copy link
Contributor Author

@aviramha Could you please add me as contributor?

@aviramha
Copy link
Owner

Hi @gburzynski-10clouds - I can consider that but I prefer to go over your contributions over time before doing that.
Happy to receive a PR.

@gburzynski-10clouds
Copy link
Contributor Author

Ah sorry, I wasn't quite familiar with the workflow. No need to add me as contributor 😄
Here's my PR #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aviramha @gburzynski-10clouds