Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: ComfyUI default config #67

Open
PieBru opened this issue Oct 29, 2024 · 2 comments
Open

FEATURE: ComfyUI default config #67

PieBru opened this issue Oct 29, 2024 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@PieBru
Copy link

PieBru commented Oct 29, 2024

Hi, this is very low priority. Harbor is so useful that it forces my laziness out of me :)

I just installed ComfyUI, and I think a newcomer (like me) user experience can be even better.

  1. As mentioned in comfyui expects localhost #50 a LAN server URL redirects to localhost. I tried harbor config set COMFYUI_URL http://harborai.lan:34032/ (both 34031 and 34032), but it continues to redirec to to localhost.

  2. After manually setting the hostname in the URL, here is the second CTF puzzle: the login. It's quite obvious to the experienced Harbor user, but IMO newcomers will appreciate if the installation phase shows a follow-up message to the user, something like:

Before accessing ComfyUI, please have a look at, and eventually modify, its configuration:
harbor config ls | grep -i comfyui
harbor config set COMFYUI_USER IamComfy
harbor config set COMFYUI_PASSWORD my_S3cret!

Thank you

@av av added bug Something isn't working documentation Improvements or additions to documentation labels Nov 2, 2024
@av
Copy link
Owner

av commented Nov 2, 2024

Hi, sorry for a delayed response.

Firstly, huge thanks for this and the other reports you made! It's a great help for the project!

  1. I think that authentication redirect can be configured using DIRECT_ADDRESS env var from the ai-dock base image

  2. v0.2.15 makes a few changes to this

  • ComfyUI auth is now turned off by default (I got into this problem myself last week, after not using it for a while) - took a a bit to investigate why it's not working out-of-the-box
    • Unfortunately Open WebUI integration simply won't work with auth enabled (no workaround)
    • We'll re-enable when Open WebUI allows auth parameters for ComfyUI connection config (either a header or a query string param at the current stage)
  • ComfyUI docs were revamped with clearer outline of authentication-related features: https://github.com/av/harbor/wiki/2.1.2-Frontend:-ComfyUI#authentication

@kosteva
Copy link

kosteva commented Nov 4, 2024

  1. As mentioned in comfyui expects localhost #50 a LAN server URL redirects to localhost. I tried harbor config set COMFYUI_URL http://harborai.lan:34032/ (both 34031 and 34032), but it continues to redirec to to localhost.

for my money, i solved this by setting this in ./comfyui/override.env:

DIRECT_ADDRESS=x.x.x.x

where x.x.x.x is the address of the server I run and access harbor on - internally, you can still refer to it as http://comfyui (in the webui), but this is what got it to finally function for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants