Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable upnp in libp2p #2625

Closed
dtynn opened this issue Mar 16, 2024 · 3 comments
Closed

Enable upnp in libp2p #2625

dtynn opened this issue Mar 16, 2024 · 3 comments
Labels
networking Subspace networking (DSN)

Comments

@dtynn
Copy link

dtynn commented Mar 16, 2024

Hi, would like to know if changes in  #4057 feat(p2p): enable UPnP to improve reachability are helpful for subspace nodes & farmers in some situations.

You can see the diffs on my own fork.

I've already check the libp2p version in both projects, and there should be no compatible problems.

Remind me if you want a pr for this~ 😉

@nazar-pc nazar-pc added the networking Subspace networking (DSN) label Mar 16, 2024
@nazar-pc
Copy link
Member

Honestly I'm reluctant to having UPnP support and would rather prefer users creating static port forwarding manually instead.

UPnP is a very insecure protocol and anyone who cares about security should disable in their router anyway.

@shamil-gadelshin do you have a strong opinion about this?

@shamil-gadelshin
Copy link
Contributor

Users don't change the default router settings in most cases. And it seems that upnp became disabled by default in modern routers because of security concerns as Nazar mentioned. It seems a nice feature to have because it can improve the overall connectivity of the network, however, I agree that if the user needs a router settings change it's better to have port forwarding instead. Also, this change would require extensive testing with the network scan to prove that the number of available addresses increased after the change.

@nazar-pc
Copy link
Member

@dtynn thanks for suggestion, but I think we will not introduce UPnP support, at least for now. We do plan to have hole punching through NAT more generally at some point, which will have a similar benefit, see #1022

@nazar-pc nazar-pc closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking Subspace networking (DSN)
Projects
None yet
Development

No branches or pull requests

3 participants