Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection Request validation using Pydantic #149

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft

Connection Request validation using Pydantic #149

wants to merge 64 commits into from

Conversation

sajith
Copy link
Member

@sajith sajith commented Sep 3, 2024

Addresses #148.

@sajith
Move new requests to its own directory
abb4195 
These follow provisioning spec v1.0.

https://sdx-docs.readthedocs.io/en/latest/specs/provisioning-api-1.0.html
@sajith
Drop importlib-resources dependency
44163e4 
We do not care for Python 3.8 anymore, so we can safely drop this
backward-compatibility library now.
@sajith
Call the test data files V1, not V2
374396a 
These connection request files are based on Service Provisioning Data
Model Specification 1.0, so they should be V1.

https://sdx-docs.readthedocs.io/en/latest/specs/provisioning-api-1.0.html

Perhaps the older requests could be renamed V0?
@sajith
Rename test requests for consistency
4f0fda6
@sajith
Reformat v1 connection request files
846c974 
Used `python -m json.tool <input> <output>`.
@sajith
Add the very basic pydantic ConnectionRequestV1 model
07ac1d6
@sajith
Add the basic v1 connection request
8600def
@sajith
Add a test case for connection request handling with pydantic
4338b87
@sajith sajith linked an issue Sep 3, 2024 that may be closed by this pull request
Importing connection request data mutates it #148
Open
@coveralls
Copy link

coveralls commented Sep 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12241147147

Details

  • 93 of 93 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 78.801%
Totals Coverage Status
Change from base Build 12123696176: 1.2%
Covered Lines: 1420
Relevant Lines: 1802
💛 - Coveralls

sajith added 22 commits September 10, 2024 11:41
@sajith
Really require all requested ranges to be the same
698351e
@sajith
Update tests for requests containing VLAN ranges
06708cc
@sajith
Add a TODO item
d6ce5f8
@sajith
Use valid VLANs in example connection request
bc48bc7
@sajith
Validate the example test request
30dd99c
@sajith
Use valid VLAN in sample connection request
a120971
@sajith
Rename a test
b40c8f3
@sajith
Add docstring
c8b7877
@sajith
Describe tests
63d2719
@sajith
Remove duplicate test
e71cb36
@sajith
Describe tests correctly
128b835
@sajith
Test with two notification emails
fd79c49
@sajith
Test ranges like n1:n2 where n2 < n1
5bafe5a
@sajith
Add a model to represent connection requests in original format
1a1851a
@sajith
Add tests for the existing v0 connection request samples
4cda1c0
@sajith
Update v0 fields
1f333e3
@sajith
Handle more v0 connection request fields
84771ad
@sajith
Move v0 connection request tests to its own class
ca4338c
@sajith
Avoid deprecated parse_file() in v0 tests
06da599
@sajith
Avoid deprecated parse_file()
ef2c250
@sajith
Run isort
68cb5ee
@sajith
Rename a test case to avoid redefinition
f561b58
@sajith sajith linked an issue Sep 13, 2024 that may be closed by this pull request
Invalid v1.0 format connection request #150
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing connection request data mutates it Invalid v1.0 format connection request
2 participants
@sajith @coveralls