Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializing dynamically #13

Open
DieterHolvoet opened this issue Jan 4, 2017 · 3 comments
Open

Initializing dynamically #13

DieterHolvoet opened this issue Jan 4, 2017 · 3 comments

Comments

@DieterHolvoet
Copy link

Hi,
Could you make it possible to somehow load new instances dynamically, instead of only on page load? For example, by exposing a function that accepts an element.

@mikayla-maki
Copy link

mikayla-maki commented Jan 4, 2017

Alternatively (or in addition), event delegating allows this feature to be implemented transparently, no API needed. And if you're worried about performance you can add a data-vocalizer-event-source attribute (or something like that) that causes vocalizer.js to bind event listeners to those elements instead of document.

I've actually done some work with event delegation before, and I'd be happy to implement the feature if the maintainer is interested.

@atifazam
Copy link
Owner

atifazam commented Jan 5, 2017

@DieterHolvoet Yes, definitely!

@makicode That would be great. I will be adding the un-minified source to the repo later on today. Thanks.

@atifazam
Copy link
Owner

atifazam commented Jan 9, 2017

@makicode I just added the source files - feel free to submit PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants