Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The game doesn't exit properly #38

Open
ThielHater opened this issue Mar 5, 2017 · 5 comments
Open

The game doesn't exit properly #38

ThielHater opened this issue Mar 5, 2017 · 5 comments

Comments

@ThielHater
Copy link
Contributor

This should be well known and it would be great, if this could be fixed somehow.

@jkelin
Copy link

jkelin commented Mar 12, 2017

It would also be great if when right clicking on game on taskbar and selecting close, it would be closed.

@BonneCW
Copy link

BonneCW commented Dec 3, 2017

Fixes for this are:

  1. GSky.cpp add
    NightTexture = nullptr;
    in c'tor. Otherwise it leads to random crashes when exiting the game as long as no NightTexture was loaded (e.g. from Main Menu)

  2. Remove deletion of DeferredContext in in d'tor of D3D11GraphicsEngineBase. This is more a hack than a fix, but shouldn't be a problem as it's done during shutdown only.

@Katharsas
Copy link
Collaborator

Katharsas commented Dec 7, 2017

Nice work, but 2. doesn't work for me, even when i check out BonneCW@0edfaba i still get a crash (currently testing on G2).

Edit:
When quitting from loaded game, log:

...
Info: Shutting down...
Info: Shut down RenderingThreadPool
Info: Shut down AntTweakBar
Info: D'Tor GothicAPI Start
Info: D'Tor GothicAPI ResetWorld
Info: D'Tor GothicAPI Ocean
Info: D'Tor GSky Start
Info: D'Tor GSky SkyPlaneVertexBuffer

When quitting from main menu before loading a game:

...
Info: D'Tor D3D11GraphicsEngine Start

@BonneCW
Copy link

BonneCW commented Dec 7, 2017

Hm, weird, I tested with Odyssee and while it always hung up when leaving the game before the fix it works now. You're testing with plain G2?

EDIT: Ah, I see...

@Katharsas
Copy link
Collaborator

Katharsas commented Dec 7, 2017

Yes plain G2. Only tested on AMD so far, will try NVidia too.
Edit: Quitting without crash works on NVidia, just not on AMD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants