fix: fixed the excessive unused white space on the right-hand side. #3593
Conversation
hkv24
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request involves a minor modification to the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
asyncapi-bot
requested review from
devilkiller-ag,
sambhavgupta0705,
BhaswatiRoy,
J0SAL,
TRohit20 and
VaishnaviNandakumar
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3593 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3593--asyncapi-website.netlify.app/ |
fix: removed md:full
hkv24
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
components/newsroom/Newsroom.tsx (2)
Line range hint
72-78: Consider simplifying the nested flex container structure.The current implementation uses multiple nested containers with absolute positioning, which might cause layout issues:
- Potential overflow problems
- Complex height calculations
- Possible content clipping
Consider this simplified structure:
- <div className='relative flex w-full flex-col overflow-y-auto'> - <div className='min-h-0'> - <div className='md:t-0 md:b-0 md:l-0 md:r-0 size-full md:absolute'> - <NewsroomArticle /> - </div> - </div> - </div> + <div className='w-full overflow-y-auto'> + <NewsroomArticle /> + </div>
Line range hint
1-106: Address performance concerns highlighted in Lighthouse report.Given the low performance score (35), consider implementing these optimizations:
- Lazy load the social media sections
- Add loading states to prevent layout shifts
- Implement proper height reservations for dynamic content
Example implementation:
import dynamic from 'next/dynamic'; // Lazy load components with social media embeds const NewsroomYoutube = dynamic(() => import('./NewsroomYoutube'), { loading: () => <div className="h-120 animate-pulse bg-gray-100" />, ssr: false }); const NewsroomArticle = dynamic(() => import('./NewsroomArticle'), { loading: () => <div className="h-120 animate-pulse bg-gray-100" />, ssr: false });Would you like me to create a separate issue to track these performance improvements?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/newsroom/Newsroom.tsx(1 hunks)
🔇 Additional comments (1)
components/newsroom/Newsroom.tsx (1)
72-72: LGTM! The layout change effectively addresses the white space issue.The removal of the
md:w-1/2class is appropriate as it maintains consistency with the component's responsive design while eliminating excessive white space.
Description
Fixes #3587
Summary by CodeRabbit