Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add github action to web docs #1644

Merged
merged 2 commits into from
Jan 24, 2025
Merged

chore: add github action to web docs #1644

merged 2 commits into from
Jan 24, 2025

Conversation

Shurtu-gal
Copy link
Collaborator

Description

  • This is to add action docs to website as only root README is visible at marketplace.

Related issue(s)

@Shurtu-gal Shurtu-gal self-assigned this Jan 24, 2025
@Shurtu-gal Shurtu-gal requested a review from derberg January 24, 2025 09:42
derberg
derberg reviewed Jan 24, 2025
View reviewed changes
github-action/README.md


This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification. Contributions of any kind welcome!
The detailed docs can be found [here](../docs/github-action.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better link to docs on website

link will be https://www.asyncapi.com/docs/tools/cli/installation/github-action

derberg
derberg reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect 👏🏼

@Shurtu-gal
Copy link
Collaborator Author

/ptal

@asyncapi-bot
Copy link
Contributor

@Amzani @Souvikns @AayushSaini101 Please take a look at this PR. Thanks! 👋

AayushSaini101
AayushSaini101 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@AayushSaini101 AayushSaini101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 1beeeb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Shurtu-gal Shurtu-gal merged commit b2711af into asyncapi:master Jan 24, 2025
22 checks passed
@Shurtu-gal Shurtu-gal deleted the action/docs branch January 24, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg left review comments

@AayushSaini101 AayushSaini101 AayushSaini101 approved these changes

@Souvikns Souvikns Awaiting requested review from Souvikns Souvikns is a code owner

@Amzani Amzani Awaiting requested review from Amzani Amzani is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

@Shurtu-gal Shurtu-gal

Labels
None yet
Projects
CLI - Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shurtu-gal @asyncapi-bot @derberg @AayushSaini101