-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo in instructions #42
Comments
Thanks for pointing that out. That indeed was a typo. I have corrected it now. 🙂 |
One more thing that may help improve the documentation: The instruction to install the dependencies (pip3 install -r requirements.txt) comes after activating the virtual environment. Subsequently, the instructions say to open a terminal and run the Sanctuary WebSockets Server. Thus the latter does not have access to any dependencies that needed to be installed because the former was done inside the virtual environment. In my case, for instance, I had to install websockets a second time even though I correctly executed the dependency installation step. A simple fix may be to move the step to install the dependencies prior to the step to activate the virtual environment. |
The
That is an intended instruction. This is to ensure that all the requirements that are fetched should be limited to these scripts only and not modify those of outside.
I appreciate your attention. That is indeed correct when you say that the Sanctuary WebSockets Server will not have access to the installed dependencies as previously they were done exclusively inside the virtual environment. We can simply fix that by activating the virtual environment for the other terminal first before running the server. I have fixed that in the documentation now to make it more clear. 🙂 |
From the instructions:
http://< YOUR-LOCAL-IP-ADDRESS >/6969/
should rather say
http://< YOUR-LOCAL-IP-ADDRESS >:6969/
The text was updated successfully, but these errors were encountered: