Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in instructions #42

Open
electricimp123 opened this issue Jul 23, 2020 · 3 comments
Open

typo in instructions #42

electricimp123 opened this issue Jul 23, 2020 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@electricimp123
Copy link

electricimp123 commented Jul 23, 2020

From the instructions:

http://< YOUR-LOCAL-IP-ADDRESS >/6969/
should rather say
http://< YOUR-LOCAL-IP-ADDRESS >:6969/

@gridhead
Copy link
Member

Thanks for pointing that out. That indeed was a typo. I have corrected it now. 🙂

@gridhead gridhead added the documentation Improvements or additions to documentation label Jul 24, 2020
@electricimp123
Copy link
Author

One more thing that may help improve the documentation:

The instruction to install the dependencies (pip3 install -r requirements.txt) comes after activating the virtual environment. Subsequently, the instructions say to open a terminal and run the Sanctuary WebSockets Server. Thus the latter does not have access to any dependencies that needed to be installed because the former was done inside the virtual environment.

In my case, for instance, I had to install websockets a second time even though I correctly executed the dependency installation step.

A simple fix may be to move the step to install the dependencies prior to the step to activate the virtual environment.

@gridhead
Copy link
Member

The virtualenv is a necessity for ensuring that the dependencies of the script serve the intended script only so when a new terminal is opened and a script is executed - it would require activation of that specific virtual environment.

The instruction to install the dependencies pip3 install -r requirements.txt comes after activating the virtual environment.

That is an intended instruction. This is to ensure that all the requirements that are fetched should be limited to these scripts only and not modify those of outside.

Subsequently, the instructions say to open a terminal and run the Sanctuary WebSockets Server. Thus the latter does not have access to any dependencies that needed to be installed because the former was done inside the virtual environment.

I appreciate your attention. That is indeed correct when you say that the Sanctuary WebSockets Server will not have access to the installed dependencies as previously they were done exclusively inside the virtual environment. We can simply fix that by activating the virtual environment for the other terminal first before running the server.

I have fixed that in the documentation now to make it more clear. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants