Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_points method name is confusing #417

Closed
smcguire-cmu opened this issue Nov 12, 2024 · 2 comments · Fixed by #439
Closed

plot_points method name is confusing #417

smcguire-cmu opened this issue Nov 12, 2024 · 2 comments · Fixed by #439
Assignees
Labels
bug Something isn't working

Comments

@smcguire-cmu
Copy link
Contributor

smcguire-cmu commented Nov 12, 2024

The inspection method plot_points is confusing in name and axes label. The name implies plotting actual points, not the density of points at the histogram order, and there is no axes label saying what the colors are plotting. And the numbers on the colorbar are not so useful (number of points per histogram order healpix pixel)

@nevencaplar nevencaplar added the bug Something isn't working label Nov 13, 2024
@delucchi-cmu
Copy link
Contributor

I'd suggest having the plot title something like f"Number of points in each order {order} pixel"

@nevencaplar
Copy link
Member

Add the name should be something like plot_density_pixel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
3 participants