-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to http headers again #410
Comments
I would rather not proliferate |
Yes! This is much much better now with this new version! def get_upath(path: str | Path | UPath, **storage_options) -> UPath:
"""Returns a file pointer from a path string"""
if not path:
return None
if isinstance(path, UPath):
return path
return UPath(path, **storage_options) Maybe I should just rename the storage_options to something else. |
Ah! I meant that you can call the upath constructor in your user code instead. e.g.
|
That's wonderful, works perfectly! Im closing the PRs |
Since version 0.4, HTTP headers are no longer passed into the reader anymore (previously contained in the storage_options), which affects access to protected data that relies on these headers (e.g., for authentication).
To address this, we can use **kwargs in the appropriate places to reintroduce header support. I’ll create a PR to implement this fix.
The text was updated successfully, but these errors were encountered: