You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We allow sorting of the HealpixPixel class with the default data class behavior (first sorting by order, then pixel). I think it's probably more useful to have sorting by higher order pixel number, and I think there are a few instances in the codebase where this behavior is expected and pixel sorting is used incorrectly.
The text was updated successfully, but these errors were encountered:
We have a hats.get_pixel_argsort method that will sort by higher order. This is already used in a handful of places in LSDB. Are there specific locations where we're using an incorrect sorting?
I think I was actually misreading the code where I thought this was a problem, sorry! I'm still not sure I particularly like the idea of HealpixPixels being ordered, that at least when I saw the uses of it after a while, I assumed the behavior was sorting by the healpix_29 of the pixels, not order then pixel. But that might just be a me problem, and if other people like it we can just close this issue.
We allow sorting of the
HealpixPixel
class with the default data class behavior (first sorting by order, then pixel). I think it's probably more useful to have sorting by higher order pixel number, and I think there are a few instances in the codebase where this behavior is expected and pixel sorting is used incorrectly.The text was updated successfully, but these errors were encountered: