Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healpix sorting behavior is ambiguous #364

Closed
smcguire-cmu opened this issue Oct 2, 2024 · 2 comments
Closed

Healpix sorting behavior is ambiguous #364

smcguire-cmu opened this issue Oct 2, 2024 · 2 comments

Comments

@smcguire-cmu
Copy link
Contributor

We allow sorting of the HealpixPixel class with the default data class behavior (first sorting by order, then pixel). I think it's probably more useful to have sorting by higher order pixel number, and I think there are a few instances in the codebase where this behavior is expected and pixel sorting is used incorrectly.

@smcguire-cmu smcguire-cmu changed the title Healpix sorting is ambiguous Healpix sorting behavior is ambiguous Oct 2, 2024
@delucchi-cmu
Copy link
Contributor

We have a hats.get_pixel_argsort method that will sort by higher order. This is already used in a handful of places in LSDB. Are there specific locations where we're using an incorrect sorting?

@smcguire-cmu
Copy link
Contributor Author

I think I was actually misreading the code where I thought this was a problem, sorry! I'm still not sure I particularly like the idea of HealpixPixels being ordered, that at least when I saw the uses of it after a while, I assumed the behavior was sorting by the healpix_29 of the pixels, not order then pixel. But that might just be a me problem, and if other people like it we can just close this issue.

@nevencaplar nevencaplar closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants