Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RobotLib with plugins, pull YARP network wrapper interfaces from new repo #122

Closed
PeterBowman opened this issue Jan 27, 2018 · 3 comments
Assignees

Comments

@PeterBowman
Copy link
Member

Former YARP device implementations of the IRobotManager class have been migrated to a new repository (asrob-uc3m/yarp-devices#1). This centralization efforts mean that we'll no longer want to maintain duplicates in src/libraries/RobotLib, namely:

  • IRobotManager.hpp should disappear, all copies will be overhauled by IRobotManager.hpp@yarp-devices
  • YarpRobotManager is a dupe of RobotClient implemented as a static library (changes should be performed to handle a DL module now)
  • MockRobotManager should be transferred into a new YARP device

Aditionally, YCM will take care of the build automatization. Specifically, that single header (for now!) would be pulled and configured by YCM if not found on the system (according to YCM standards, we'll need a BuildASROB_YARP_DEVICES.cmake). We can take advantage from some ideas laid out at roboticslab-uc3m/questions-and-answers/issues/44 (interface targets).

@PeterBowman PeterBowman changed the title Refactor RobotLib with plugins, pull YARP network wrappers interfaces from new repo Refactor RobotLib with plugins, pull YARP network wrapper interfaces from new repo Jan 28, 2018
@PeterBowman PeterBowman self-assigned this Feb 9, 2018
@PeterBowman
Copy link
Member Author

Updated CMake configuration of device repo at asrob-uc3m/yarp-devices@19b5e12.

@PeterBowman
Copy link
Member Author

I'll leave some lines for the automation of color-debug via YCM. The actual migration may/will happen at #123.

@PeterBowman
Copy link
Member Author

Mixing YCM with interface targets (in order to propagate the path to IRobotManager.h from asrob-uc3m/yarp-devices) was quite messy. I summed it up and left some hopefully useful pointers at roboticslab-uc3m/developer-manual#18 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants