Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating tab not working on windows since Firefox 132.0 (64-Bit) #80

Open
sebi8642 opened this issue Nov 1, 2024 · 5 comments
Open

Comments

@sebi8642
Copy link

sebi8642 commented Nov 1, 2024

Describe the bug
The main content window does not have the "Arc" or "Edge" floating effect anymore since Firefox 132.0 (64-Bit). I have tried reinstalling the complete theme, without success. Especially the right side is annoying.

To Reproduce
Steps to reproduce the behavior:
Update to Firefox 132.0 (64-Bit) on Windows 11

Expected behavior
With the toggle of the about:config settings "uc.tweak.floating-tabs" and "uc.tweak.rounded-corners" the desired effect should take action.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 11 23H2
  • Firefox 132.0 (64-Bit)
@ChelsyMena
Copy link

Having this same issue after the firefox update.

@sebi8642
Copy link
Author

sebi8642 commented Nov 2, 2024

Finally found something: Mozilla changed some variable names (and behavior?) which messed with the code. I am no expert with CSS but I managed to get a passable version by adding the following lines to the userChrome.css:

#tabbrowser-tabbox{
padding: 8px !important;
}
tabbox#tabbrowser-tabbox browser{
border-radius: 10px !important;
}

@peterahn8
Copy link

Finally found something: Mozilla changed some variable names (and behavior?) which messed with the code. I am no expert with CSS but I managed to get a passable version by adding the following lines to the userChrome.css:

#tabbrowser-tabbox{ padding: 8px !important; } tabbox#tabbrowser-tabbox browser{ border-radius: 10px !important; }

Nice catch and clever workaround 👍

We can also try changing #appcontent to #browser:
CleanShot 2024-11-02 at 12 49 04 AM@2x

Maybe #appcontent is no longer an id in Firefox 132. It might have been renamed to #browser. Or maybe the DOM got shifted entirely

@ChelsyMena
Copy link

Finally found something: Mozilla changed some variable names (and behavior?) which messed with the code. I am no expert with CSS but I managed to get a passable version by adding the following lines to the userChrome.css:
#tabbrowser-tabbox{ padding: 8px !important; } tabbox#tabbrowser-tabbox browser{ border-radius: 10px !important; }

Nice catch and clever workaround 👍

We can also try changing #appcontent to #browser: CleanShot 2024-11-02 at 12 49 04 AM@2x

Maybe #appcontent is no longer an id in Firefox 132. It might have been renamed to #browser. Or maybe the DOM got shifted entirely

Instant Fix, thanks!

@aaajhs
Copy link

aaajhs commented Nov 30, 2024

Hi all, I submitted PR #86 that would apply @peterahn8's solution to the codebase. It should fix the issue for Windows/Mac users who have updated to Firefox v132.

It doesn't look like the PRs are actively reviewed by the owner, so unless there are other issues overlooked with the fix I will come back to it in a few weeks' time to merge. Please feel free to review.

I suggest we close this issue, @sebi8642, as we have a solution and a PR underway.
And again, full credits to @peterahn8 for the solution.

EDIT: Unfortunately I do not have the permission to merge. Looks like we'll have to wait for the codeowner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants