Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS in Twig templates #109

Open
chadtomkiss-tbp opened this issue Jun 19, 2019 · 1 comment
Open

XSS in Twig templates #109

chadtomkiss-tbp opened this issue Jun 19, 2019 · 1 comment

Comments

@chadtomkiss-tbp
Copy link

When using HAML and Twig to render our templates, we have run into an issue that allows XSS.

- set name = '"><script>alert(1);</script>'

%input(value=name)

The compiled template is:

{% set name = '"><script>alert(1);</script>' %}
<input {{ mthaml_attributes([['value', name]], 'html5', 'UTF-8', false)|raw }}>

We are using the Symfony bundle, which disables escaping by default.

Is there anything we need to do to prevent this?

@arnaud-lb
Copy link
Owner

I see no reason for not escaping attributes. I've fixed that and tagged 1.8.1.

Thank you for reporting this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants