From da9bcdb28c47bb1e6954c98c2434bfca55daa410 Mon Sep 17 00:00:00 2001 From: JamesMurkin Date: Tue, 6 Feb 2024 11:20:16 +0000 Subject: [PATCH] Use minimal instead of minimal-pulsar Signed-off-by: JamesMurkin --- .github/workflows/python-client.yml | 2 +- .github/workflows/test.yml | 2 +- docs/developer.md | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/python-client.yml b/.github/workflows/python-client.yml index 0896bbaf6f9..f5ffffcd223 100644 --- a/.github/workflows/python-client.yml +++ b/.github/workflows/python-client.yml @@ -81,7 +81,7 @@ jobs: # Manually create folders to ensure perms are correct. mkdir -p .kube/internal mkdir -p .kube/external - go run github.com/magefile/mage@v1.14.0 -v localdev minimal-pulsar + go run github.com/magefile/mage@v1.14.0 -v localdev minimal - name: Install Protoc uses: arduino/setup-protoc@v2 with: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 970375e3f0b..0618cccc227 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -116,7 +116,7 @@ jobs: cache-tools: true - name: Setup Integration Tests - run: go run github.com/magefile/mage@v1.14.0 -v localdev minimal-pulsar + run: go run github.com/magefile/mage@v1.14.0 -v localdev minimal - name: Run Integration Tests run: go run github.com/magefile/mage@v1.14.0 -v testsuite diff --git a/docs/developer.md b/docs/developer.md index 7cf712091f3..da17d54c60a 100644 --- a/docs/developer.md +++ b/docs/developer.md @@ -9,7 +9,7 @@ This document is intended for developers who want to contribute to the project. Want to quickly get Armada running and test it? Install the [Pre-requisites](#pre-requisites) and then run: ```bash -mage localdev minimal-pulsar testsuite +mage localdev minimal testsuite ``` To get the UI running, run: @@ -76,10 +76,10 @@ LocalDev provides a reliable and extendable way to install Armada as a developer It has the following options to customize further steps: * `mage localdev full` - Runs all components of Armada, including the Lookout UI. -* `mage localdev minimal-pulsar` - Runs only the core components of Armada (such as the API server and an executor). +* `mage localdev minimal` - Runs only the core components of Armada (such as the API server and an executor). * `mage localdev no-build` - Skips the build step; set `ARMADA_IMAGE` and `ARMADA_TAG` to choose the Docker image to use. -`mage localdev minimal-pulsar` is what is used to test the CI pipeline, and is the recommended way to test changes to the core components of Armada. +`mage localdev minimal` is what is used to test the CI pipeline, and is the recommended way to test changes to the core components of Armada. ## Debug error saying that the (port 6443 is already in use) after running mage localdev full @@ -150,7 +150,7 @@ mage LocalDevStop And then run ```bash -mage LocalDev minimal-pulsar +mage LocalDev minimal ``` Ensure your local dev environment is completely torn down when switching between pulsar backed and legacy