Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contributing.md #4

Open
arjunsinghy96 opened this issue Oct 26, 2018 · 2 comments
Open

Update Contributing.md #4

arjunsinghy96 opened this issue Oct 26, 2018 · 2 comments
Labels
difficulty:normal Issue require some work and time hacktoberfest This issue is simple enough to be a first pull request.

Comments

@arjunsinghy96
Copy link
Owner

Update the contributing.md with basic contribution guidelines. Few things can be:

  • all code should be tested
  • don't use the master branch
  • Make atomic commit such that they solve one and only one particular issue.
  • The commit should refer to the issue they solve.
  • rebase branch to current master before opening a PR
@arjunsinghy96
Copy link
Owner Author

Should contain

  • Commit guideline. Summarize coala good commit

  • Rebase the branch to master before creating the PR (Idea is to maintain linear commit history)

  • Request to get assigned to the issue before taking it up.

  • Don't try to work on already assigned issue.

and similar things. More suggestion are welcome

@arjunsinghy96 arjunsinghy96 added hacktoberfest This issue is simple enough to be a first pull request. difficulty:normal Issue require some work and time labels Oct 28, 2018
@arjunsinghy96
Copy link
Owner Author

Request to get assigned to this issue. First to request gets assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:normal Issue require some work and time hacktoberfest This issue is simple enough to be a first pull request.
Projects
None yet
Development

No branches or pull requests

1 participant